Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 885553005: Collect phantom callback data only once during gc. For scavenges, just consider the young handles r… (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@weak-allocation-sites
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Collect phantom callback data only once during gc. For scavenges, just consider the young handles referenced by young generation. BUG= Committed: https://crrev.com/9b60e894828532a22b272502128de870b36a6aa7 Cr-Commit-Position: refs/heads/master@{#26344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M src/global-handles.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/global-handles.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
5 years, 10 months ago (2015-01-29 21:00:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-01-30 08:14:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885553005/1
5 years, 10 months ago (2015-01-30 08:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 08:22:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 08:23:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b60e894828532a22b272502128de870b36a6aa7
Cr-Commit-Position: refs/heads/master@{#26344}

Powered by Google App Engine
This is Rietveld 408576698