pkg/args: a bunch of test cleanup

pkg/args/test/args_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library args_test;
 
 import 'package:unittest/unittest.dart';
 import 'package:args/args.dart';
+import 'utils.dart';
 
-main() {
+void main() {
   group('ArgParser.addFlag()', () {
     test('throws ArgumentError if the flag already exists', () {
       var parser = new ArgParser();
       parser.addFlag('foo');
       throwsIllegalArg(() => parser.addFlag('foo'));
     });
 
     test('throws ArgumentError if the option already exists', () {
       var parser = new ArgParser();
       parser.addOption('foo');
@@ skipping 154 matching lines @@
     test('iterates over the options in the order they were added', () {
       var parser = new ArgParser();
       parser.addFlag('a');
       parser.addOption('d');
       parser.addFlag('b');
       parser.addOption('c');
       expect(parser.options.keys, equals(['a', 'd', 'b', 'c']));
     });
   });
 
-  group('ArgResults.options', () {
-    test('returns the provided options', () {
-      var parser = new ArgParser();
-      parser.addFlag('woof');
-      parser.addOption('meow');
-      var args = parser.parse(['--woof', '--meow', 'kitty']);
-      expect(args.options, hasLength(2));
-      expect(args.options.any((o) => o == 'woof'), isTrue);
-      expect(args.options.any((o) => o == 'meow'), isTrue);
+  group('ArgResults', () {
+    group('options', () {
+      test('returns the provided options', () {
+        var parser = new ArgParser();
+        parser.addFlag('woof');
+        parser.addOption('meow');
+        var args = parser.parse(['--woof', '--meow', 'kitty']);
+        expect(args.options, hasLength(2));
+        expect(args.options, contains('woof'));
+        expect(args.options, contains('meow'));
+      });
+
+      test('includes defaulted options', () {
+        var parser = new ArgParser();
+        parser.addFlag('woof', defaultsTo: false);
+        parser.addOption('meow', defaultsTo: 'kitty');
+        var args = parser.parse([]);
+        expect(args.options, hasLength(2));
+        expect(args.options, contains('woof'));
+        expect(args.options, contains('meow'));
+      });
     });
 
-    test('includes defaulted options', () {
-      var parser = new ArgParser();
-      parser.addFlag('woof', defaultsTo: false);
-      parser.addOption('meow', defaultsTo: 'kitty');
-      var args = parser.parse([]);
-      expect(args.options, hasLength(2));
-      expect(args.options.any((o) => o == 'woof'), isTrue);
-      expect(args.options.any((o) => o == 'meow'), isTrue);
-    });
-  });
-
-  group('ArgResults[]', () {
-    test('throws if the name is not an option', () {
+    test('[] throws if the name is not an option', () {
       var parser = new ArgParser();
       var results = parser.parse([]);
       throwsIllegalArg(() => results['unknown']);
     });
+
+    test('rest cannot be modified', () {
+      var results = new ArgResults({}, '', null, []);
+      expect(() => results.rest.add('oops'), throwsUnsupportedError);
+    });
   });
 }
 
-throwsIllegalArg(function, {String reason: null}) {
-  expect(function, throwsArgumentError, reason: reason);
-}
-
-throwsFormat(ArgParser parser, List<String> args) {
-  expect(() => parser.parse(args), throwsFormatException);
-}
-
 const _INVALID_OPTIONS = const [
  ' ', '', '-', '--', '--foo',
  ' with space',
  'with\ttab',
  'with\rcarriage\rreturn',
  'with\nline\nfeed',
  "'singlequotes'",
  '"doublequotes"',
  'back\\slash',
  'forward/slash'
 ];
 
 const _VALID_OPTIONS = const [
  'a' // one char
  'contains-dash',
  'contains_underscore',
  'ends-with-dash-',
  'contains--doubledash--',
  '1starts-with-number',
  'contains-a-1number',
  'ends-with-a-number8'
 ];