Upstream script to get "salient" image from webpage.

Upstream script to get "salient" image from webpage.

This is used by enhanced bookmarks to choose an image to show for each
bookmark.

BUG=450287
Committed: https://crrev.com/189f9ba326f89d6baa2fef0f565a98f6f75ab42e
Cr-Commit-Position: refs/heads/master@{#313440}

[newt (away), 2015-01-27 23:38:04]

newt@chromium.org changed reviewers:
+ estade@chromium.org, kkimlabs@chromium.org

[newt (away), 2015-01-27 23:38:05]

PTAL

[Kibeom Kim (inactive), 2015-01-28 00:05:46]

lgtm

[Evan Stade, 2015-01-28 00:08:24]

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/get_salient_image_url.js (right):

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:47: for (var ii = 0; ii <
images.length; ii++) {
why ii?

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:50: if (aspectRatio >= 2.4 ||
aspectRatio <= 0.5) {
nit: no curlies

[Kibeom Kim (inactive), 2015-01-28 00:14:18]

+cc noyau

[newt (away), 2015-01-28 00:19:51]

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/get_salient_image_url.js (right):

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:47: for (var ii = 0; ii <
images.length; ii++) {
On 2015/01/28 00:08:24, Evan Stade wrote:
> why ii?

No idea. Changed it to i.

https://codereview.chromium.org/885513002/diff/20001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:50: if (aspectRatio >= 2.4 ||
aspectRatio <= 0.5) {
On 2015/01/28 00:08:24, Evan Stade wrote:
> nit: no curlies

Done.

[Evan Stade, 2015-01-28 00:30:46]

lgtm

[newt (away), 2015-01-28 00:30:57]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-01-28 00:30:59]

The CQ bit was unchecked by newt@chromium.org

[newt (away), 2015-01-28 00:31:44]

newt@chromium.org changed reviewers:
+ thakis@chromium.org

[newt (away), 2015-01-28 00:31:45]

+thakis for browser_resources.grd

[Nico, 2015-01-28 01:18:28]

lgtm with typos fixed

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/get_salient_image_url.js (right):

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:20: // See what to use for
JSON. Some pages uses a library that overrides JSON.
*some pages use

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:28: // Checks that the url in
ogImage has a path that conatians more than just a
*contains

[Nico, 2015-01-28 01:18:45]

also, why is the bug private?

[newt (away), 2015-01-28 01:28:38]

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/get_salient_image_url.js (right):

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:20: // See what to use for
JSON. Some pages uses a library that overrides JSON.
On 2015/01/28 01:18:28, Nico wrote:
> *some pages use

Done.

https://codereview.chromium.org/885513002/diff/40001/chrome/browser/resources...
chrome/browser/resources/get_salient_image_url.js:28: // Checks that the url in
ogImage has a path that conatians more than just a
On 2015/01/28 01:18:28, Nico wrote:
> *contains

Done.

[newt (away), 2015-01-28 01:28:40]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-28 01:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885513002/60001

[commit-bot: I haz the power, 2015-01-28 04:20:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-28 04:21:23]

Patchset 4 (id:??) landed as
https://crrev.com/189f9ba326f89d6baa2fef0f565a98f6f75ab42e
Cr-Commit-Position: refs/heads/master@{#313440}