extensions/renderer/dispatcher.cc - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert key of IsolatedWorldMap as std::string. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_guest.cc ('K') | « extensions/extensions.gypi ('k') | extensions/renderer/extension_injection_host.h » ('j') | extensions/renderer/script_injection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index 4a4dd2ac1483fbd420377e5c69261cd0896b5726..7c02403b894aae4c777fec78379e4eb88520db1c 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -235,7 +235,7 @@ const Extension* Dispatcher::GetExtensionFromFrameAndWorld(

std::string extension_id;

if (world_id != 0) {

// Isolated worlds (content script).

- extension_id = ScriptInjection::GetExtensionIdForIsolatedWorld(world_id);

+ extension_id = ScriptInjection::GetHostIdForIsolatedWorld(world_id);

} else if (!frame->document().securityOrigin().isUnique()) {

// TODO(kalman): Delete the above check.