extensions/common/host_id.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/host_id.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert key of IsolatedWorldMap as std::string. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_guest.cc ('K') | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | extensions/common/host_id.cc » ('j') | extensions/renderer/script_injection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/host_id.h

diff --git a/extensions/common/host_id.h b/extensions/common/host_id.h

index 004480704f07766662006c7c3c570883c7e9a296..f311612eea1ab9a376bd39ae6abd1d09946a7b6d 100644

--- a/extensions/common/host_id.h

+++ b/extensions/common/host_id.h

@@ -13,16 +13,11 @@ struct HostID {

enum HostType { EXTENSIONS, WEBUI };

HostID() {}

- HostID(HostType type, const std::string& id)

- : type_(type), id_(id) {}

- bool operator<(const HostID& host_id) const {

- if (type_ != host_id.type())

- return type_ < host_id.type();

- else if (id_ != host_id.id())

- return id_ < host_id.id();

- return false;

- }

+ HostID(HostType type, const std::string& id);

+ HostID(const HostID& host_id);

+ bool operator<(const HostID& host_id) const;

+ bool operator==(const HostID& host_id) const;

HostType type() const { return type_; }

const std::string& id() const { return id_; }