extensions/browser/guest_view/web_view/web_view_guest.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Devlin's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_view/web_view_internal_api.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 2e399ea92c3e057e99c1537674875f4f243e8aa3..275989ddd77328db54afc7413d372f9288a5680d 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -7,6 +7,7 @@

#include <vector>

+#include "base/callback.h"

#include "base/observer_list.h"

#include "content/public/browser/javascript_dialog_manager.h"

#include "content/public/browser/notification_observer.h"

@@ -62,6 +63,12 @@ class WebViewGuest : public GuestView<WebViewGuest>,

int embedder_process_id,

int web_view_instance_id);

+ // Return the stored script injection instance ID of the given guest.

+ // Will generate an ID for the first query.

+ static int GetOrGenerateScriptInjectionInstanceID(

+ int embedder_process_id,

+ int guest_instance_id);

// Request navigating the guest to the provided |src| URL.

void NavigateGuest(const std::string& src, bool force_navigation);