extensions/renderer/script_injector.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injector.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Host::IsEmpty() and move ExtensionConsumer to extensions/renderer. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/script_injection_manager.cc ('K') | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/user_script_injector.h » ('j') | extensions/renderer/user_script_injector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_injector.h

diff --git a/extensions/renderer/script_injector.h b/extensions/renderer/script_injector.h

index 9b4aca96b9d479b39652b54aa21de60d538f9629..3a12dc4f01c4bc846b83f6a9fef11a3c65a17642 100644

--- a/extensions/renderer/script_injector.h

+++ b/extensions/renderer/script_injector.h

@@ -12,6 +12,7 @@

#include "extensions/common/user_script.h"

#include "third_party/WebKit/public/web/WebScriptSource.h"

+class Host;

class GURL;

namespace blink {

@@ -61,7 +62,7 @@ class ScriptInjector {

// Returns true if the script should execute on the given |frame|.

virtual PermissionsData::AccessType CanExecuteOnFrame(

- const Extension* extension,

+ const Host* host,

blink::WebFrame* web_frame,

int tab_id,

const GURL& top_url) const = 0;