extensions/browser/api/execute_code_function.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/execute_code_function.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Host::IsEmpty() and move ExtensionConsumer to extensions/renderer. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | extensions/browser/api/execute_code_function.cc » ('j') | extensions/common/extension_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/execute_code_function.h

diff --git a/extensions/browser/api/execute_code_function.h b/extensions/browser/api/execute_code_function.h

index 9e1593a9d3ea3a87a120c11b925ab238a8327c11..0f26a6b33a35b840b41d9e77b9d32294a0a03a2e 100644

--- a/extensions/browser/api/execute_code_function.h

+++ b/extensions/browser/api/execute_code_function.h

@@ -32,6 +32,7 @@ class ExecuteCodeFunction : public AsyncExtensionFunction {

virtual ScriptExecutor* GetScriptExecutor() = 0;

virtual bool IsWebView() const = 0;

virtual const GURL& GetWebViewSrc() const = 0;

+ virtual int GetScriptInjectionInstanceId() const = 0;

virtual void OnExecuteCodeFinished(const std::string& error,

const GURL& on_url,

const base::ListValue& result);