Refactoring: de-couple Extensions from "script injection System" [render side] : 1

extensions/renderer/programmatic_script_injector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/programmatic_script_injector.h"
 
 #include <vector>
 
 #include "base/values.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"

[Devlin, 2015/02/11 00:00:48]

Prune

[Xi Han, 2015/02/11 16:00:23]

Done.

 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/renderer/script_context.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebScriptSource.h"
 
 namespace extensions {
@@ skipping 36 matching lines @@
     UserScript::RunLocation run_location) const {
   return GetRunLocation() == run_location && params_->is_javascript;
 }
 
 bool ProgrammaticScriptInjector::ShouldInjectCss(
     UserScript::RunLocation run_location) const {
   return GetRunLocation() == run_location && !params_->is_javascript;
 }
 
 PermissionsData::AccessType ProgrammaticScriptInjector::CanExecuteOnFrame(
-    const Extension* extension,
+    const InjectionHost* injection_host,
     blink::WebFrame* frame,
     int tab_id,
     const GURL& top_url) const {
   GURL effective_document_url = ScriptContext::GetEffectiveDocumentURL(
       frame, frame->document().url(), params_->match_about_blank);
   if (params_->is_web_view) {
     if (frame->parent()) {
       // This is a subframe inside <webview>, so allow it.
       return PermissionsData::ACCESS_ALLOWED;
     }
 
     return effective_document_url == params_->webview_src
                ? PermissionsData::ACCESS_ALLOWED
                : PermissionsData::ACCESS_DENIED;
   }
 
-  return extension->permissions_data()->GetPageAccess(extension,
-                                                      effective_document_url,
-                                                      top_url,
-                                                      tab_id,
-                                                      -1,  // no process ID.
-                                                      NULL /* ignore error */);
+  return injection_host->CanExecuteOnFrame(
+      effective_document_url, top_url, tab_id, true /* is_declarative */);
 }
 
 std::vector<blink::WebScriptSource> ProgrammaticScriptInjector::GetJsSources(
     UserScript::RunLocation run_location) const {
   DCHECK_EQ(GetRunLocation(), run_location);
   DCHECK(params_->is_javascript);
 
   return std::vector<blink::WebScriptSource>(
       1,
       blink::WebScriptSource(
@@ skipping 40 matching lines @@
 
   render_view_->Send(new ExtensionHostMsg_ExecuteCodeFinished(
       render_view_->GetRoutingID(),
       params_->request_id,
       error,
       url_,
       *results_));
 }
 
 }  // namespace extensions