Refactoring: de-couple Extensions from "script injection System" [render side] : 1

extensions/renderer/extension_injection_host.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/common/manifest_handlers/csp_info.h"
+#include "extensions/renderer/extension_injection_host.h"
+
+namespace extensions {
+
+ExtensionInjectionHost::ExtensionInjectionHost(
+    const scoped_refptr<const Extension>& extension)
+    : InjectionHost(HostID(HostID::EXTENSIONS, extension->id())),
+      extension_(extension) {

[Devlin, 2015/02/11 00:00:48]

CHECK(extension_)

[Xi Han, 2015/02/11 16:00:23]

Do you mean CHECK(extension_.get())? Since we already call extension->id() in
line12, it will break if the extension is nullptr. Is this CHECK really
necessary here?

[Devlin, 2015/02/11 20:19:44]

Hm. Good point.

+}
+
+ExtensionInjectionHost::~ExtensionInjectionHost() {
+}
+
+const std::string& ExtensionInjectionHost::GetContentSecurityPolicy() const {
+  return CSPInfo::GetContentSecurityPolicy(extension_.get());
+}
+
+const GURL& ExtensionInjectionHost::url() const {
+  return extension_->url();
+}
+
+const std::string ExtensionInjectionHost::name() const {
+  return extension_->name();
+}
+
+PermissionsData::AccessType ExtensionInjectionHost::CanExecuteOnFrame(
+      const GURL& document_url,
+      const GURL& top_frame_url,
+      int tab_id,
+      bool is_declarative) const {
+  // Declarative user scripts use "page access" (from "permissions" section in
+  // manifest) whereas non-declarative user scripts use custom
+  // "content script access" logic.
+  if (is_declarative) {
+    return extension_->permissions_data()->GetPageAccess(
+        extension_.get(),
+        document_url,
+        top_frame_url,
+        tab_id,
+        -1,  // no process id
+        nullptr /* ignore error */);
+  } else {
+    return extension_->permissions_data()->GetContentScriptAccess(
+        extension_.get(),
+        document_url,
+        top_frame_url,
+        tab_id,
+        -1,  // no process id
+        nullptr /* ignore error */);
+  }
+}
+
+}  // namespace extensions