Refactoring: de-couple Extensions from "script injection System" [render side] : 1

extensions/renderer/user_script_injector.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_
 #define EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/scoped_observer.h"
 #include "extensions/common/user_script.h"
 #include "extensions/renderer/script_injection.h"
 #include "extensions/renderer/user_script_set.h"
 
+class Host;
+
 namespace blink {
 class WebFrame;
 }
 
 namespace extensions {
 class Extension;

[Devlin, 2015/02/09 17:40:25]

Here too

[Xi Han, 2015/02/09 23:28:12]

Done.

 
 // A ScriptInjector for UserScripts.
 class UserScriptInjector : public ScriptInjector,
                            public UserScriptSet::Observer {
  public:
   UserScriptInjector(const UserScript* user_script,
                      UserScriptSet* user_script_set,
                      bool is_declarative);
   ~UserScriptInjector() override;
 
  private:
   // UserScriptSet::Observer implementation.
   void OnUserScriptsUpdated(const std::set<std::string>& changed_extensions,
                             const std::vector<UserScript*>& scripts) override;
 
   // ScriptInjector implementation.
   UserScript::InjectionType script_type() const override;
   bool ShouldExecuteInChildFrames() const override;
   bool ShouldExecuteInMainWorld() const override;
   bool IsUserGesture() const override;
   bool ExpectsResults() const override;
   bool ShouldInjectJs(UserScript::RunLocation run_location) const override;
   bool ShouldInjectCss(UserScript::RunLocation run_location) const override;
   PermissionsData::AccessType CanExecuteOnFrame(
-      const Extension* extension,
+      const Host* host,
       blink::WebFrame* web_frame,
       int tab_id,
       const GURL& top_url) const override;
   std::vector<blink::WebScriptSource> GetJsSources(
       UserScript::RunLocation run_location) const override;
   std::vector<std::string> GetCssSources(
       UserScript::RunLocation run_location) const override;
   void OnInjectionComplete(scoped_ptr<base::ListValue> execution_results,
                            ScriptsRunInfo* scripts_run_info,
                            UserScript::RunLocation run_location) override;
@@ skipping 17 matching lines @@
 
   ScopedObserver<UserScriptSet, UserScriptSet::Observer>
       user_script_set_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(UserScriptInjector);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_