chrome/browser/profiles/profiles_state.h - Issue 885493005: Setting Guest last-active for the User Manager doesn't create the Guest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profiles_state.h

Issue 885493005: Setting Guest last-active for the User Manager doesn't create the Guest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac UserManager asyncly creates Guest for Controller Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/profiles/profiles_state.h

diff --git a/chrome/browser/profiles/profiles_state.h b/chrome/browser/profiles/profiles_state.h

index 71bb26760cca745856dd24cd348fec85a23ea79b..6142f9d5cf144f56f8bd962a8b06c6111dd5fec1 100644

--- a/chrome/browser/profiles/profiles_state.h

+++ b/chrome/browser/profiles/profiles_state.h

@@ -73,9 +73,9 @@ void UpdateGaiaProfileInfoIfNeeded(Profile* profile);

SigninErrorController* GetSigninErrorController(Profile* profile);

// If the current active profile (given by prefs::kProfileLastUsed) is locked,

-// changes the active profile to the Guest profile and returns it, otherwise

-// returns NULL. This assumes that the Guest profile has been loaded.

-Profile* SetActiveProfileToGuestIfLocked();

+// changes the active profile to the Guest profile. Returns true if the active

+// profile is now guest.

noms (inactive) 2015/01/29 16:15:13 Hmm, this comment is a bit confusing. Why wouldn't

Mike Lerman 2015/01/29 16:51:40 Done.

+bool SetActiveProfileToGuestIfLocked();

} // namespace profiles

« no previous file with comments | « no previous file | chrome/browser/profiles/profiles_state.cc » ('j') | chrome/browser/profiles/profiles_state.cc » ('J')