Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 885493004: [Telemetry] Remove empty_action_name_to_run for tab_switching (Closed)

Created:
5 years, 11 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove empty_action_name_to_run for tab_switching Remove scrolling action for pages of Top10PageSet. Measurements that are paired with Top10PageSet are TabSwitching & PageCycler. Both of these originally set action_name_to_run='' which means that they don't expect RunPageInteraction to run anything. BUG=418375 Committed: https://crrev.com/b83bcccc6666071524a10d46c36aa25e83f15a19 Cr-Commit-Position: refs/heads/master@{#313534}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_10.py View 6 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
5 years, 11 months ago (2015-01-28 00:16:12 UTC) #3
sullivan
lgtm
5 years, 11 months ago (2015-01-28 03:56:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885493004/20001
5 years, 10 months ago (2015-01-28 16:01:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-28 17:19:42 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 17:21:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83bcccc6666071524a10d46c36aa25e83f15a19
Cr-Commit-Position: refs/heads/master@{#313534}

Powered by Google App Engine
This is Rietveld 408576698