Issue 885483002: Oilpan: tidy up prefinalizer declarations and a registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885483002: Oilpan: tidy up prefinalizer declarations and a registration. (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-rendering, jchaffraix+rendering, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: tidy up prefinalizer declarations and a registration. Use transition macro WILL_BE_USING_PRE_FINALIZER() where possible, and add a missing prefinalizer registration for MIDIAccessInitializer. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189094

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -21 lines)			Patch
M	Source/core/dom/MutationObserver.h	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderScrollbar.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/modules/webmidi/MIDIAccessInitializer.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/modules/webmidi/MIDIAccessInitializer.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/platform/LifecycleObserver.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885483002/1

5 years, 10 months ago (2015-01-28 06:15:40 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 06:19:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189094

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages