Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/sqlite/patches/0004-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch

Issue 885473002: [sql] Rewrite sqlite patching "system". (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed typo in readme. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/sqlite/patches/0004-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch
diff --git a/third_party/sqlite/separate_cache_pool.patch b/third_party/sqlite/patches/0004-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch
similarity index 59%
rename from third_party/sqlite/separate_cache_pool.patch
rename to third_party/sqlite/patches/0004-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch
index cf22f355ff0da15c329251d94446f3e34a368db8..5514ec354626f181854f376f2ce3ecc348efd40d 100644
--- a/third_party/sqlite/separate_cache_pool.patch
+++ b/third_party/sqlite/patches/0004-Use-seperate-page-cache-pools-for-each-sqlite-connec.patch
@@ -1,7 +1,24 @@
-diff --git src/pcache1.c src/pcache1.c
+From 22030cd2e05e746a169066c37b28c580b0a57284 Mon Sep 17 00:00:00 2001
+From: rmcilroy <rmcilroy@chromium.org>
+Date: Thu, 20 Jun 2013 22:50:12 +0000
+Subject: [PATCH 04/23] Use seperate page-cache pools for each sqlite
+ connection.
+
+Due to multiple different subsystems using sqlite, the shared global page
+cache policy does not suite our use-cases on Chrome very well. This CL
+enables a compile time flag to be set to disable shared cache pools.
+
+BUG=243769
+
+Original review URL: https://chromiumcodereview.appspot.com/17413004
+---
+ third_party/sqlite/src/src/pcache1.c | 8 ++++++--
+ 1 file changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/third_party/sqlite/src/src/pcache1.c b/third_party/sqlite/src/src/pcache1.c
index ad44395..e4d0705 100644
---- src/pcache1.c
-+++ src/pcache1.c
+--- a/third_party/sqlite/src/src/pcache1.c
++++ b/third_party/sqlite/src/src/pcache1.c
@@ -549,10 +549,12 @@ static sqlite3_pcache *pcache1Create(int szPage, int bPurgeable){
int sz; /* Bytes of memory required to allocate the new cache */
@@ -27,3 +44,6 @@ index ad44395..e4d0705 100644
const int separateCache = 0;
#else
int separateCache = sqlite3GlobalConfig.bCoreMutex>0;
+--
+2.2.1
+

Powered by Google App Engine
This is Rietveld 408576698