content/browser/renderer_host/web_input_event_aura_unittest.cc - Issue 885463002: Disable WebInputEventAuraTest.TestMakeWebKeyboardEventWindowsKeyCode under TSan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 885463002: Disable WebInputEventAuraTest.TestMakeWebKeyboardEventWindowsKeyCode under TSan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/web_input_event_aura_unittest.cc

diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc

index 0e6fd82a7a645256206784dd9cb28b94ed871d43..892af7b5b64083390bfd4a26248c13ebada23a78 100644

--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc

+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc

@@ -45,8 +45,8 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {

}

// Checks that MakeWebKeyboardEvent returns a correct windowsKeyCode.

-#if defined(THREAD_SANITIZER)

-// This test fails under ThreadSanitizer on Linux, see

+#if defined(OS_CHROMEOS) || defined(THREAD_SANITIZER)

+// Fails on Chrome OS and under ThreadSanitizer on Linux, see

// https://crbug.com/449103.

#define MAYBE_TestMakeWebKeyboardEventWindowsKeyCode \

DISABLED_TestMakeWebKeyboardEventWindowsKeyCode

« no previous file with comments | « no previous file | no next file » | no next file with comments »