Issue 885453003: Remove ChannelManager::AddChannel().

Issue 885453003: Remove ChannelManager::AddChannel(). (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove ChannelManager::AddChannel(). I.e., convert tests. Also add a GetChannel() method and remove (the private) GetChannelInfo(). R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a93dbd432e517f4a71f576e91214c059bab7c43b

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -84 lines)			Patch
M	mojo/edk/embedder/embedder.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel_manager.h	View	3 chunks	+10 lines, -19 lines	0 comments	Download
M	mojo/edk/system/channel_manager.cc	View	2 chunks	+9 lines, -16 lines	0 comments	Download
M	mojo/edk/system/channel_manager_unittest.cc	View	6 chunks	+58 lines, -47 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yzshen1

lgtm https://codereview.chromium.org/885453003/diff/1/mojo/edk/system/channel_manager_unittest.cc File mojo/edk/system/channel_manager_unittest.cc (right): https://codereview.chromium.org/885453003/diff/1/mojo/edk/system/channel_manager_unittest.cc#newcode51 mojo/edk/system/channel_manager_unittest.cc:51: scoped_refptr<ChannelEndpoint> cep; nit: naming variables like this is ...

5 years, 10 months ago (2015-02-04 17:26:39 UTC) #2

viettrungluu

On 2015/02/04 17:26:39, yzshen1 wrote: > lgtm > > https://codereview.chromium.org/885453003/diff/1/mojo/edk/system/channel_manager_unittest.cc > File mojo/edk/system/channel_manager_unittest.cc (right): > ...

5 years, 10 months ago (2015-02-04 17:31:34 UTC) #3

viettrungluu

5 years, 10 months ago (2015-02-04 17:32:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a93dbd432e517f4a71f576e91214c059bab7c43b (presubmit successful).

Expand Messages | Collapse Messages