Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: extensions/browser/extension_function.h

Issue 885443010: WebstorePrivate extension API cleanup, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@testext_permission_prompt
Patch Set: remove dispatcher dependency Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index 0fccce5b50ea12008452f6f079ba180a305977b0..a427a60b30cf7da362ec9fec3f9e1f68025722f1 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -308,6 +308,12 @@ class ExtensionFunction
const std::string& s1,
const std::string& s2,
const std::string& s3);
+ // Error with a list of arguments |args| to pass to caller. TAKES OWNERSHIP.
+ // Using this ResponseValue indicates something is wrong with the API.
+ // It shouldn't be possible to have both an error *and* some arguments.
+ // Some legacy APIs do rely on it though, like webstorePrivate.
+ ResponseValue ErrorWithArguments(scoped_ptr<base::ListValue> args,
+ const std::string& error);
// Bad message. A ResponseValue equivalent to EXTENSION_FUNCTION_VALIDATE(),
// so this will actually kill the renderer and not respond at all.
ResponseValue BadMessage();
« no previous file with comments | « chrome/test/data/extensions/api_test/webstore_private/icon_url.js ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698