content/child/service_worker/service_worker_provider_context.h - Issue 885443006: ServiceWorker: Get registration info and its version attributes in one lock operation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_provider_context.h

Issue 885443006: ServiceWorker: Get registration info and its version attributes in one lock operation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/child/service_worker/service_worker_provider_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_provider_context.h

diff --git a/content/child/service_worker/service_worker_provider_context.h b/content/child/service_worker/service_worker_provider_context.h

index e858ea9e743e843e544d1913fa2b11e0312fcb9c..b54c7993ff18e0a9637f6ab872c57fde99b1b71e 100644

--- a/content/child/service_worker/service_worker_provider_context.h

+++ b/content/child/service_worker/service_worker_provider_context.h

@@ -48,9 +48,10 @@ class ServiceWorkerProviderContext

int provider_id() const { return provider_id_; }

ServiceWorkerHandleReference* controller();

- ServiceWorkerRegistrationHandleReference* registration();

- ServiceWorkerVersionAttributes GetVersionAttributes();

+ bool GetRegistrationInfoAndVersionAttributes(

+ ServiceWorkerRegistrationObjectInfo* info,

+ ServiceWorkerVersionAttributes* attrs);

void SetVersionAttributes(ChangedVersionAttributesMask mask,

const ServiceWorkerVersionAttributes& attrs);