Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 885443005: Update tracing includes in .mm files and generator for /ui (Closed)

Created:
5 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Nico, no sievers
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update tracing includes in .mm files and generator for /ui This is a follow up to crrev.com/866893002 which fixed the tracing includes without updating the generator. This CL involves mostly mechanical changes to trace include headers. See crrev.com/837303004 and the related bug for motivations. BUG=451032 TBR=thakis@chromium.org Committed: https://crrev.com/51a9c2e81d6e39833e6bcea20b377675bfd3e465 Cr-Commit-Position: refs/heads/master@{#313484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M ui/accelerated_widget_mac/accelerated_widget_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_context.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_layer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_texture.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/software_layer.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/generate_bindings.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Primiano Tucci (use gerrit)
5 years, 11 months ago (2015-01-28 01:02:35 UTC) #2
no sievers
lgtm. thanks!
5 years, 11 months ago (2015-01-28 02:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885443005/1
5 years, 10 months ago (2015-01-28 07:18:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38818)
5 years, 10 months ago (2015-01-28 07:23:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885443005/1
5 years, 10 months ago (2015-01-28 10:44:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 11:59:14 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51a9c2e81d6e39833e6bcea20b377675bfd3e465 Cr-Commit-Position: refs/heads/master@{#313484}
5 years, 10 months ago (2015-01-28 12:01:06 UTC) #12
Nico
5 years, 10 months ago (2015-01-28 17:42:03 UTC) #13
Message was sent while issue was closed.
rs-lgtm

(when tbr'ing something, say "tbr thakis for foo/" in the email message. Else,
I'll get a completely empty and context-free email when I'm cc'd on the thread
mid-review and more often than not I don't click through when I get these)

Powered by Google App Engine
This is Rietveld 408576698