Index: base/message_loop/message_loop.cc |
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc |
index 86771e43ae6c5075e5ab2c9dd76bfdb750e52dc2..24db543ed87b0bdc9a933b4e7b64236390d203a8 100644 |
--- a/base/message_loop/message_loop.cc |
+++ b/base/message_loop/message_loop.cc |
@@ -5,6 +5,7 @@ |
#include "base/message_loop/message_loop.h" |
#include <algorithm> |
+#include <limits> |
#include "base/bind.h" |
#include "base/compiler_specific.h" |
@@ -43,6 +44,12 @@ namespace { |
LazyInstance<base::ThreadLocalPointer<MessageLoop> >::Leaky lazy_tls_ptr = |
LAZY_INSTANCE_INITIALIZER; |
+// Delays larger than this many microseconds are likely bogus, and a warning |
+// should be emitted in debug builds to warn developers. |
+// http://crbug.com/450045 |
+const int kTaskDelayWarningThresholdInMicroseconds = |
+ std::numeric_limits<int>::max() / 2; |
+ |
// Logical events for Histogram profiling. Run with -message-loop-histogrammer |
// to get an accounting of messages and actions taken on each thread. |
const int kTaskRunEvent = 0x1; |
@@ -279,6 +286,10 @@ void MessageLoop::PostDelayedTask( |
const Closure& task, |
TimeDelta delay) { |
DCHECK(!task.is_null()) << from_here.ToString(); |
+ DLOG_IF(WARNING, |
+ delay.InMicroseconds() > kTaskDelayWarningThresholdInMicroseconds) |
+ << "Requesting super-long task delay period of " << delay.InMicroseconds() |
+ << " usec from " << from_here.ToString(); |
incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, true); |
} |
@@ -294,6 +305,10 @@ void MessageLoop::PostNonNestableDelayedTask( |
const Closure& task, |
TimeDelta delay) { |
DCHECK(!task.is_null()) << from_here.ToString(); |
+ DLOG_IF(WARNING, |
+ delay.InMicroseconds() > kTaskDelayWarningThresholdInMicroseconds) |
+ << "Requesting super-long task delay period of " << delay.InMicroseconds() |
+ << " usec from " << from_here.ToString(); |
incoming_task_queue_->AddToIncomingQueue(from_here, task, delay, false); |
} |