dm/DMGpuTask.cpp - Issue 88543002: DM: some refactoring - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(324)

My Issues | Starred Open | Closed | All

Unified Diff: dm/DMGpuTask.cpp

Issue 88543002: DM: some refactoring (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« dm/DMChecksumTask.cpp ('K') | « dm/DMCpuTask.cpp ('k') | dm/DMPipeTask.cpp » ('j') | dm/DMPipeTask.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dm/DMGpuTask.cpp

diff --git a/dm/DMGpuTask.cpp b/dm/DMGpuTask.cpp

index 4d99356237b3188b472058b018911afc1df0873a..d4c4254c62fbabfdb820f4314784cc156a44d390 100644

--- a/dm/DMGpuTask.cpp

+++ b/dm/DMGpuTask.cpp

@@ -1,6 +1,6 @@

#include "DMGpuTask.h"

-#include "DMComparisonTask.h"

+#include "DMChecksumTask.h"

#include "DMUtil.h"

#include "DMWriteTask.h"

#include "SkCommandLineFlags.h"

@@ -60,9 +60,7 @@ void GpuTask::draw() {

gr->printCacheStats();

#endif

- // We offload checksum comparison to the main CPU threadpool.

- // This cuts run time by about 30%.

- this->spawnChild(SkNEW_ARGS(ComparisonTask, (*this, fExpectations, bitmap)));

+ this->spawnChild(SkNEW_ARGS(ChecksumTask, (*this, fExpectations, bitmap)));

this->spawnChild(SkNEW_ARGS(WriteTask, (*this, bitmap)));

}

« dm/DMChecksumTask.cpp ('K') | « dm/DMCpuTask.cpp ('k') | dm/DMPipeTask.cpp » ('j') | dm/DMPipeTask.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698