DM: some refactoring

dm/DMReporter.cpp

 #include "DMReporter.h"
 
 #include "SkCommandLineFlags.h"
 
 DEFINE_bool(quiet, false, "If true, don't print status updates.");
 
 namespace DM {
 
 void Reporter::updateStatusLine() const {
     if (FLAGS_quiet) {
         return;
     }
 
     SkString status;
-    status.printf("\r\033[K%d / %d", this->finished(), this->started());
+    status.printf("\r\033[K%d tasks left", this->started() - this->finished());

[epoger, 2013/11/26 17:55:22]

This user prefers to see "completed X of Y", rather than just "(Y-X) remaining".

[bsalomon, 2013/11/26 18:21:52]

That is potentially misleading as Y grows in DM.

[mtklein, 2013/11/26 18:25:30]

Have you run this or just talking abstractly?  I'd be surprised if you really
preferred X of Y here.  Y increases as the program goes along, sometimes as fast
as X.  Y-X is a much better indicator of time remaining.

[epoger, 2013/11/26 18:34:48]

I have not run DM, and it's not a big deal to me either way... but given that Y
grows, it seems *especially* useful to know both X and Y at any given point.

Most users, given X and Y, will be able to calculate Y-X. :-)

At any rate... the more info, the better.

     const int failed = this->failed();
     if (failed > 0) {
         status.appendf(", %d failed", failed);
     }
     SkDebugf(status.c_str());
 }
 
 int32_t Reporter::failed() const {
     SkAutoMutexAcquire reader(&fMutex);
     return fFailures.count();
 }
 
 void Reporter::fail(SkString name) {
     SkAutoMutexAcquire writer(&fMutex);
     fFailures.push_back(name);
 }
 
 void Reporter::getFailures(SkTArray<SkString>* failures) const {
     SkAutoMutexAcquire reader(&fMutex);
     *failures = fFailures;
 }
 
 }  // namespace DM