Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: dm/DMPipeTask.cpp

Issue 88543002: DM: some refactoring (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #include "DMPipeTask.h" 1 #include "DMPipeTask.h"
2 #include "DMUtil.h" 2 #include "DMUtil.h"
3 #include "DMWriteTask.h" 3 #include "DMWriteTask.h"
4 4
5 #include "SamplePipeControllers.h" 5 #include "SamplePipeControllers.h"
6 #include "SkCommandLineFlags.h" 6 #include "SkCommandLineFlags.h"
7 #include "SkGPipe.h" 7 #include "SkGPipe.h"
8 8
9 DEFINE_bool(pipe, false, "If true, check several pipe variants against the refer ence bitmap."); 9 DEFINE_bool(pipe, true, "If true, check several pipe variants against the refere nce bitmap.");
epoger 2013/11/26 17:55:22 If it's not too much trouble, I would recommend se
mtklein 2013/11/26 18:25:30 Yeah, ordinarily I'm with you, but here this isn't
10 10
11 namespace DM { 11 namespace DM {
12 12
13 static uint32_t get_flags(bool crossProcess, bool sharedAddressSpace) { 13 static uint32_t get_flags(bool crossProcess, bool sharedAddressSpace) {
14 SkASSERT(!(!crossProcess && sharedAddressSpace)); 14 SkASSERT(!(!crossProcess && sharedAddressSpace));
15 uint32_t flags = 0; 15 uint32_t flags = 0;
16 if (crossProcess) { 16 if (crossProcess) {
17 flags |= SkGPipeWriter::kCrossProcess_Flag; 17 flags |= SkGPipeWriter::kCrossProcess_Flag;
18 if (sharedAddressSpace) { 18 if (sharedAddressSpace) {
19 flags |= SkGPipeWriter::kSharedAddressSpace_Flag; 19 flags |= SkGPipeWriter::kSharedAddressSpace_Flag;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 return true; 75 return true;
76 } 76 }
77 if (fFlags == SkGPipeWriter::kCrossProcess_Flag && 77 if (fFlags == SkGPipeWriter::kCrossProcess_Flag &&
78 fGM->getFlags() & skiagm::GM::kSkipPipeCrossProcess_Flag) { 78 fGM->getFlags() & skiagm::GM::kSkipPipeCrossProcess_Flag) {
79 return true; 79 return true;
80 } 80 }
81 return false; 81 return false;
82 } 82 }
83 83
84 } // namespace DM 84 } // namespace DM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698