Add the ability to change directories before execing.

base/process/process_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _CRT_SECURE_NO_WARNINGS
 
 #include <limits>
 
 #include "base/command_line.h"
 #include "base/debug/alias.h"
@@ skipping 1005 matching lines @@
     RAW_CHECK(getpid() == ctid);
     _exit(kSuccess);
   }
 
   ASSERT_NE(-1, pid);
   int status = 42;
   ASSERT_EQ(pid, HANDLE_EINTR(waitpid(pid, &status, 0)));
   ASSERT_TRUE(WIFEXITED(status));
   EXPECT_EQ(kSuccess, WEXITSTATUS(status));
 }
+
+MULTIPROCESS_TEST_MAIN(CheckCwdProcess) {
+  base::FilePath expected;
+  CHECK(base::GetTempDir(&expected));
+  base::FilePath actual;
+  CHECK(base::GetCurrentDirectory(&actual));
+  CHECK(actual == expected);
+  return kSuccess;
+}
+
+TEST_F(ProcessUtilTest, CurrentDirectory) {
+  base::FilePath orig_cwd;
+  ASSERT_TRUE(base::GetCurrentDirectory(&orig_cwd));
+  ASSERT_TRUE(base::SetCurrentDirectory(base::FilePath("/")));
+
+  base::FilePath tmp_dir;
+  ASSERT_TRUE(base::GetTempDir(&tmp_dir));
+
+  base::LaunchOptions options;
+  options.current_directory = tmp_dir;
+
+  base::Process process(SpawnChildWithOptions("CheckCwdProcess", options));
+  ASSERT_TRUE(process.IsValid());
+
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExit(&exit_code));
+  EXPECT_EQ(kSuccess, exit_code);
+
+  ASSERT_TRUE(base::SetCurrentDirectory(orig_cwd));

[jln (very slow on Chromium), 2015/01/31 00:21:56]

You could put this in a ClosureRunner instead, but it's probably not needed.

[rickyz (no longer on Chrome), 2015/01/31 00:59:37]

This ended up getting removed.

+}
+
+TEST_F(ProcessUtilTest, InvalidCurrentDirectory) {
+  base::LaunchOptions options;
+  options.current_directory = base::FilePath("/etc/passwd");

[jln (very slow on Chromium), 2015/01/31 00:21:56]

How about /dev/null? I'm not sure /etc/passwd is guaranteed by POSIX (I'm pretty
sure it won't exist on Android too).

[rickyz (no longer on Chrome), 2015/01/31 00:59:37]

Done.

+
+  base::Process process(SpawnChildWithOptions("SimpleChildProcess", options));
+  ASSERT_TRUE(process.IsValid());
+
+  int exit_code = 42;
+  EXPECT_TRUE(process.WaitForExit(&exit_code));
+  EXPECT_EQ(-1, exit_code);

[jln (very slow on Chromium), 2015/01/31 00:21:56]

Let's do EXPECT_NE(kSuccess, ...) since we're relying on undocumented oddities
of CHECK/RAW_CHECK here.

[rickyz (no longer on Chrome), 2015/01/31 00:59:37]

Done.

+}
 #endif