Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7554)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 885373004: Use customization mode by default in permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes etc. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index b8d26d5a1882a3d93349eac362d03aef1586da36..b8a53e5f08765fb3e7b7617707defa9c23b538b6 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -83,7 +83,6 @@ PermissionBubbleManager::PermissionBubbleManager(
bubble_showing_(false),
view_(NULL),
request_url_has_loaded_(false),
- customization_mode_(false),
weak_factory_(this) {}
PermissionBubbleManager::~PermissionBubbleManager() {
@@ -271,12 +270,6 @@ void PermissionBubbleManager::ToggleAccept(int request_index, bool new_value) {
accept_states_[request_index] = new_value;
}
-void PermissionBubbleManager::SetCustomizationMode() {
- customization_mode_ = true;
- if (view_)
- view_->Show(requests_, accept_states_, customization_mode_);
-}
-
void PermissionBubbleManager::Accept() {
std::vector<PermissionBubbleRequest*>::iterator requests_iter;
std::vector<bool>::iterator accepts_iter = accept_states_.begin();
@@ -352,7 +345,7 @@ void PermissionBubbleManager::TriggerShowBubble() {
// Note: this should appear above Show() for testing, since in that
// case we may do in-line calling of finalization.
bubble_showing_ = true;
- view_->Show(requests_, accept_states_, customization_mode_);
+ view_->Show(requests_, accept_states_);
}
void PermissionBubbleManager::FinalizeBubble() {

Powered by Google App Engine
This is Rietveld 408576698