dm: allow multiple --skp flags, allow single files

dm: allow multiple --skp flags, allow single files

Committed: https://skia.googlesource.com/skia/+/fc37ad168090637973bf21452aa2685cfcbb273c

[hal.canary, 2015-01-30 15:02:51]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-30 15:03:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885353002/1

[commit-bot: I haz the power, 2015-01-30 15:03:06]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-30 21:03 UTC

[hal.canary, 2015-01-30 15:04:47]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-01-30 15:04:47]

ptal

[mtklein, 2015-01-30 15:11:47]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-01-30 15:12:19]

lgtm, with some optional nits

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp#newcode125
dm/DM.cpp:125: for (int i = 0; i < FLAGS_skps.count(); ++i) {
Rest of the file uses i++.

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp#newcode133
dm/DM.cpp:133: push_src("skp", new SKPSrc(SkString(path)));
I think SKPSrc(path) will work fine here?

[hal.canary, 2015-01-30 15:19:59]

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp#newcode125
dm/DM.cpp:125: for (int i = 0; i < FLAGS_skps.count(); ++i) {
On 2015/01/30 15:12:19, mtklein wrote:
> Rest of the file uses i++.

Done.

https://codereview.chromium.org/885353002/diff/1/dm/DM.cpp#newcode133
dm/DM.cpp:133: push_src("skp", new SKPSrc(SkString(path)));
On 2015/01/30 15:12:19, mtklein wrote:
> I think SKPSrc(path) will work fine here?

It does not.

[hal.canary, 2015-01-30 15:20:18]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-30 15:21:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885353002/20001

[commit-bot: I haz the power, 2015-01-30 15:31:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fc37ad168090637973bf21452aa2685cfcbb273c

[scroggo, 2015-01-30 16:28:32]

On 2015/01/30 15:31:22, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/fc37ad168090637973bf21452aa2685cfcbb273c

+1!

IWBN to support this for images as well.