bindings: Fixes connect-helper to use stringifyDOMObject.

bindings: Fixes connect-helper to use stringifyDOMObject.

JSON.stringify doesn't work with DOMObjects/DOMExceptions when we move DOM attributes to prototype chains.  Fixes layout tests to use stringifyDOMObject instead in js-test.js.

BUG=43394
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189383

[Yuki, 2015-01-30 14:10:35]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org, jsbell@chromium.org

[Yuki, 2015-01-30 14:10:35]

Could you guys review this CL?  Thanks.

[jsbell, 2015-01-30 17:58:10]

Hrm. These are used in testharness-based tests (with an eye to upstreaming them
to web-platform-tests), so we probably don't want to introduce a dependency on
js-test.

It'd be better to add a helper to http/tests/resources/testharness-helpers.js
(i.e. utilities we hope to upstream eventually) or just make a local copy of the
stringifyDOMObject function in this helper.

https://codereview.chromium.org/885343002/diff/1/LayoutTests/http/tests/navig...
File LayoutTests/http/tests/navigatorconnect/resources/connect-helper.js
(right):

https://codereview.chromium.org/885343002/diff/1/LayoutTests/http/tests/navig...
LayoutTests/http/tests/navigatorconnect/resources/connect-helper.js:2:
importScripts("/js-test-resources/js-test.js");
Can we do this instead:

if ('importScripts' in self)
  importScripts(...);

Or at least add comment inside the try block e.g. "in case we're running in a
worker"

[Yuki, 2015-02-02 07:49:31]

Patchset #2 (id:20001) has been deleted

[Yuki, 2015-02-02 07:51:12]

Thanks for the review.  I've added stringifyDOMObject function to
testharness-helpers.js so I can use it in other tests if needed.

https://codereview.chromium.org/885343002/diff/1/LayoutTests/http/tests/navig...
File LayoutTests/http/tests/navigatorconnect/resources/connect-helper.js
(right):

https://codereview.chromium.org/885343002/diff/1/LayoutTests/http/tests/navig...
LayoutTests/http/tests/navigatorconnect/resources/connect-helper.js:2:
importScripts("/js-test-resources/js-test.js");
On 2015/01/30 17:58:10, jsbell wrote:
> Can we do this instead:
> 
> if ('importScripts' in self)
>   importScripts(...);
> 
> Or at least add comment inside the try block e.g. "in case we're running in a
> worker"

Done.

[jsbell, 2015-02-02 15:38:04]

lgtm

[haraken, 2015-02-02 23:31:31]

LGTM 2

[Yuki, 2015-02-03 04:01:21]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-02-03 04:01:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/885343002/40001

[commit-bot: I haz the power, 2015-02-03 05:20:55]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189383