Issue 885333002: CallIC used an invalid mechanism to detect if it was in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885333002: CallIC used an invalid mechanism to detect if it was in optimized code. (Closed)

Created:
5 years, 10 months ago by mvstanton

Modified:
5 years, 10 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

CallIC used an invalid mechanism to detect if it was in optimized code. BUG=453481 LOG=N R=jarin@chromium.org Committed: https://crrev.com/3df0a9ae773f26f42689311de7728a60a3af58ef Cr-Commit-Position: refs/heads/master@{#26361}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -7 lines)			Patch
	M	src/ic/ic.cc	View		1 chunk	+3 lines, -7 lines	0 comments	Download
	A	test/mjsunit/regress/regress-453481.js	View		1 chunk	+127 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

mvstanton

Hi Jaro, Here is the fix we discussed, PTAL, thanks! --Michael

5 years, 10 months ago (2015-01-30 13:50:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885333002/1

5 years, 10 months ago (2015-01-30 14:28:06 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-01-30 15:07:20 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3df0a9ae773f26f42689311de7728a60a3af58ef
Cr-Commit-Position: refs/heads/master@{#26361}