Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 885283008: MIPS64: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed)

Created:
5 years, 10 months ago by akos.palfi.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Super Constructor Calls need to use a vector slot, not an ic slot. Port 64f81870ee0bc51a32620be8face35e7cbd0da92 BUG= Committed: https://crrev.com/f37047cdbee4d8a4211017a2cd999fae2610b65d Cr-Commit-Position: refs/heads/master@{#26418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 10 months ago (2015-02-04 00:52:04 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-02-04 01:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885283008/1
5 years, 10 months ago (2015-02-04 01:28:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 01:58:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 01:58:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f37047cdbee4d8a4211017a2cd999fae2610b65d
Cr-Commit-Position: refs/heads/master@{#26418}

Powered by Google App Engine
This is Rietveld 408576698