Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/gn/binary_target_generator.cc

Issue 885283006: gn: Allow users to set 'check_includes' in action_foreach(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TargetGenerator Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/target_generator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/binary_target_generator.cc
diff --git a/tools/gn/binary_target_generator.cc b/tools/gn/binary_target_generator.cc
index deee2161b58bfe89fa8652cce05c7a5b06305c06..923d0edd7a95f37ac66538e62a67cefcf68aac52 100644
--- a/tools/gn/binary_target_generator.cc
+++ b/tools/gn/binary_target_generator.cc
@@ -63,16 +63,6 @@ void BinaryTargetGenerator::DoRun() {
return;
}
-bool BinaryTargetGenerator::FillCheckIncludes() {
- const Value* value = scope_->GetValue(variables::kCheckIncludes, true);
- if (!value)
- return true;
- if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
- return false;
- target_->set_check_includes(value->boolean_value());
- return true;
-}
-
bool BinaryTargetGenerator::FillCompleteStaticLib() {
if (target_->output_type() == Target::STATIC_LIBRARY) {
const Value* value = scope_->GetValue(variables::kCompleteStaticLib, true);
« no previous file with comments | « tools/gn/binary_target_generator.h ('k') | tools/gn/target_generator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698