Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 885283005: Update SSL/malware/net error interstitial design (Closed)

Created:
5 years, 10 months ago by edwardjung
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SSL/malware/net error interstitial design + On small screens the navigation buttons are anchored to the bottom of the screen. + Tweaks to the text colour + Change button styling of safe browsing page BUG=422882 Committed: https://crrev.com/82b22b21f1234316aa546566fe0d0d553f8dfe22 Cr-Commit-Position: refs/heads/master@{#314907}

Patch Set 1 #

Patch Set 2 : Fix for CrOS to pass errorpage browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -107 lines) Patch
M chrome/browser/resources/chromeos/neterror.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_net_load.html View 2 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.css View 1 10 chunks +369 lines, -12 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 chunk +22 lines, -17 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.js View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/resources/security_warnings/safe_browsing.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/neterror.css View 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/renderer/resources/neterror.html View 2 chunks +54 lines, -54 lines 0 comments Download
M chrome/renderer/resources/neterror.js View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
edwardjung
Erik, A thousand apologies that I'm getting you to review this same code again for ...
5 years, 10 months ago (2015-02-05 15:10:40 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-05 22:54:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885283005/20001
5 years, 10 months ago (2015-02-05 23:09:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 23:14:24 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:15:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82b22b21f1234316aa546566fe0d0d553f8dfe22
Cr-Commit-Position: refs/heads/master@{#314907}

Powered by Google App Engine
This is Rietveld 408576698