Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 885273002: Fix compile error in V4L2SliceVDA. (Closed)

Created:
5 years, 10 months ago by wuchengli
Modified:
5 years, 10 months ago
Reviewers:
achaulk, kcwu, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compile error in V4L2SliceVDA. BUG=None TEST=compile on CrOS Committed: https://crrev.com/f2343a5840885a43d09e0faab47052b007c20543 Cr-Commit-Position: refs/heads/master@{#313880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
wuchengli
PTAL.
5 years, 10 months ago (2015-01-30 07:05:00 UTC) #2
kcwu
lgtm
5 years, 10 months ago (2015-01-30 07:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885273002/1
5 years, 10 months ago (2015-01-30 07:32:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-01-30 07:32:02 UTC) #7
Pawel Osciak
lgtm
5 years, 10 months ago (2015-01-30 07:44:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885273002/1
5 years, 10 months ago (2015-01-30 07:48:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 07:52:05 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f2343a5840885a43d09e0faab47052b007c20543 Cr-Commit-Position: refs/heads/master@{#313880}
5 years, 10 months ago (2015-01-30 07:53:07 UTC) #12
Daniel Kurtz
On 2015/01/30 07:53:07, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-01-30 08:27:43 UTC) #13
Pawel Osciak
5 years, 10 months ago (2015-01-30 08:29:56 UTC) #14
Message was sent while issue was closed. 
On 2015/01/30 08:27:43, Daniel Kurtz wrote:
> On 2015/01/30 07:53:07, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/f2343a5840885a43d09e0faab47052b007c20543
> > Cr-Commit-Position: refs/heads/master@{#313880}
> 
> This was compile broken by https://codereview.chromium.org/806413004
> 
> Just curious, how did that get past the CQ?

CQ does not build ARM.

Powered by Google App Engine
This is Rietveld 408576698