Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 885233002: Cast tunnel_socket to ProxyClientSocket instead of HttpProxyClientSocket. (Closed)

Created:
5 years, 10 months ago by pcc
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cast tunnel_socket to ProxyClientSocket instead of HttpProxyClientSocket. BUG=453126 R=rch@chromium.org Committed: https://crrev.com/684f44bd654c65ed515fdb1c38536530ea66254f Cr-Commit-Position: refs/heads/master@{#313954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pcc
5 years, 10 months ago (2015-01-30 02:49:27 UTC) #1
Ryan Hamilton
lgtm Thanks!
5 years, 10 months ago (2015-01-30 04:42:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885233002/1
5 years, 10 months ago (2015-01-30 06:59:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/50250)
5 years, 10 months ago (2015-01-30 08:46:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885233002/1
5 years, 10 months ago (2015-01-30 17:12:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 18:59:50 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 19:00:32 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/684f44bd654c65ed515fdb1c38536530ea66254f
Cr-Commit-Position: refs/heads/master@{#313954}

Powered by Google App Engine
This is Rietveld 408576698