Issue 885213002: Add fling support to sky-drawer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885213002: Add fling support to sky-drawer (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
esprehn, eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr, sky

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add fling support to sky-drawer For some reason, the fling looks correct when we don't divide by the device pixel ratio when converting from mojo::Event to blink::WebInputEvent. Maybe the gesture detector is confused somehow about physical / logical pixels? R=eseidel@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/41e7c59e24b66e8ae3e3cef131de87914032ff96

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	sky/framework/sky-drawer.sky	View		3 chunks	+23 lines, -5 lines	0 comments	Download
	M	sky/viewer/converters/input_event_types.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

abarth-chromium

5 years, 10 months ago (2015-01-30 06:07:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41e7c59e24b66e8ae3e3cef131de87914032ff96 (presubmit successful).