Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 885143002: IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is givne (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, Martin Barbella, inferno
CC:
chromium-reviews, Martin Barbella
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is given This adds an option to enable ChannelMojo on ipc_fuzzer. R=inferno@chormium.org, mbarbella@chromium.org BUG=453571 Committed: https://crrev.com/9b1b6da70aab6c78bbecb5f86081ec5abc101f86 Cr-Commit-Position: refs/heads/master@{#313840}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tools/ipc_fuzzer/replay/replay.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 2 chunks +14 lines, -4 lines 1 comment Download

Messages

Total messages: 12 (3 generated)
Hajime Morrita
I havn't tried this yet, but hopefully it could work.
5 years, 10 months ago (2015-01-29 22:18:10 UTC) #1
Martin Barbella
Tom, could you take a look at this?
5 years, 10 months ago (2015-01-29 22:23:15 UTC) #4
Tom Sepez
LGTM % comment. https://codereview.chromium.org/885143002/diff/1/tools/ipc_fuzzer/replay/replay_process.cc File tools/ipc_fuzzer/replay/replay_process.cc (right): https://codereview.chromium.org/885143002/diff/1/tools/ipc_fuzzer/replay/replay_process.cc#newcode70 tools/ipc_fuzzer/replay/replay_process.cc:70: bool should_use_mojo = base::CommandLine::ForCurrentProcess()->HasSwitch( isn't this ...
5 years, 10 months ago (2015-01-29 23:41:15 UTC) #5
Tom Sepez
nit: typo "givne" in CL description.
5 years, 10 months ago (2015-01-29 23:42:05 UTC) #6
Hajime Morrita
Thanks for the review! On 2015/01/29 23:41:15, Tom Sepez wrote: > LGTM % comment. > ...
5 years, 10 months ago (2015-01-30 00:01:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885143002/1
5 years, 10 months ago (2015-01-30 00:01:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 00:38:27 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b1b6da70aab6c78bbecb5f86081ec5abc101f86 Cr-Commit-Position: refs/heads/master@{#313840}
5 years, 10 months ago (2015-01-30 00:39:19 UTC) #11
Hajime Morrita
5 years, 10 months ago (2015-01-30 18:49:21 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/893603004/ by morrita@chromium.org.

The reason for reverting is: The flag was wrong. It needs finer configuration..

Powered by Google App Engine
This is Rietveld 408576698