Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 88513002: Reland 54383003: Added an "enable-audio-processor" flag and WebRtcAudioProcessor class (Closed)

Created:
7 years ago by no longer working on chromium
Modified:
7 years ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, fischman+watch_chromium.org, wjia+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added an "enable-audio-processor" flag and WebRtcAudioProcessor class. This CL is a break-down CL from https://codereview.chromium.org/37793005. As the first step to move WebRtc APM to Chrome, it adds a enable-audio-processor command line flag, the WebRtcAudioProcessor class and its unittest. WebRtcAudioProcessor is not hooked up the any of the code in Chrome yet, but it will be exercised and tested by its unittest. TBR=tommi@chromium.org BUG=264611 TEST=content_unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237360

Patch Set 1 #

Patch Set 2 : fixed the dependency problem on the original CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+831 lines, -4 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +7 lines, -3 lines 0 comments Download
A content/renderer/media/media_stream_audio_processor.h View 1 chunk +138 lines, -0 lines 0 comments Download
A content/renderer/media/media_stream_audio_processor.cc View 1 chunk +361 lines, -0 lines 0 comments Download
A content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A content/renderer/media/media_stream_audio_processor_unittest.cc View 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/88513002/20001
7 years ago (2013-11-26 15:13:40 UTC) #1
no longer working on chromium
Tommi, FYI, I am relanding this with a fix on the dependency. SX
7 years ago (2013-11-26 15:15:56 UTC) #2
tommi (sloooow) - chröme
rs lgtm
7 years ago (2013-11-26 15:18:53 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-26 18:23:11 UTC) #4
Message was sent while issue was closed.
Change committed as 237360

Powered by Google App Engine
This is Rietveld 408576698