Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Unified Diff: chrome/browser/platform_util.h

Issue 8851007: WIP / Do not commit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/platform_util_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/platform_util.h
diff --git a/chrome/browser/platform_util.h b/chrome/browser/platform_util.h
index 69ecf986708ae76489ca128366b212d375c80e6f..97025f72e851cc15ef312a4d1c93f7cc68a9dfcf 100644
--- a/chrome/browser/platform_util.h
+++ b/chrome/browser/platform_util.h
@@ -8,6 +8,7 @@
#include <string>
+#include "base/process.h"
#include "base/string16.h"
#include "ui/gfx/native_widget_types.h"
@@ -22,7 +23,14 @@ void ShowItemInFolder(const FilePath& full_path);
// Open the given file in the desktop's default manner.
// Must be called from the UI thread.
-void OpenItem(const FilePath& full_path);
+// If |process_handle| is not NULL, it will contain the handle of the newly
+// spawned process that opened the file on Windows and Linux. On Mac or
+// Chrome OS, the process handle will be unchanged.
+// NOTE: In this case, the caller is responsible for closing the handle
+// (on Windows) / ensuring that the process gets reaped (on Linux). Otherwise
+// these things will be done automatically.
+// XXX
+void OpenItem(const FilePath& full_path, base::ProcessHandle* process_handle);
// Open the given external protocol URL in the desktop's default manner.
// (For example, mailto: URLs in the default mail user agent.)
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/platform_util_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698