Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 885063002: Hide pinch viewport scrollbars when near minimum scale. (Closed)

Created:
5 years, 10 months ago by bokan
Modified:
5 years, 10 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2272
Target Ref:
refs/pending/branch-heads/2272
Project:
chromium
Visibility:
Public.

Description

Hide pinch viewport scrollbars when near minimum scale. This patch prevents the overlay scrollbars from showing up when we're near the minimum scale. The threshold can be set per-platform; by default it's 0 so the scrollbars will be visible regardless of the scale. On Windows/Linux/CrOS we'd like to prevent the scrollbars from overlaying over the window scrollbars so we set a small non-0 threshold. BUG=446411 Review URL: https://codereview.chromium.org/877863002 Cr-Commit-Position: refs/heads/master@{#313431} (cherry picked from commit c784a6f02ed8f2cffe131c2c067c4805cd752610) Committed: https://chromium.googlesource.com/chromium/src/+/5198bfa1b299cce3eb2cccab2714f2f5465dd4b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -9 lines) Patch
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M cc/layers/scrollbar_layer_impl_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 3 chunks +69 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bokan
5 years, 10 months ago (2015-01-29 15:19:04 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5198bfa1b299cce3eb2cccab2714f2f5465dd4b6.

Powered by Google App Engine
This is Rietveld 408576698