content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 88503002: Have the unload event execute in background on cross-site navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 88503002: Have the unload event execute in background on cross-site navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Charlie's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 318fb62f16bc980634bf89b757205924d5524707..8849581b2df92570c23085c31f40e86f9ce0db8d 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -1097,6 +1097,7 @@ TEST_F(NavigationControllerTest, LoadURL_WithBindings) {

contents()->GetPendingRenderViewHost()->AllowBindings(1);

static_cast<TestRenderViewHost*>(

contents()->GetPendingRenderViewHost())->SendNavigate(1, url2);

+ orig_rvh->OnSwappedOut(false);

// The second load should be committed, and bindings should be remembered.

EXPECT_EQ(controller.GetEntryCount(), 2);