Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 88503002: Have the unload event execute in background on cross-site navigations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Charlie's comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/callback.h"
12 #include "base/compiler_specific.h" 13 #include "base/compiler_specific.h"
13 #include "base/logging.h" 14 #include "base/logging.h"
14 #include "base/memory/scoped_ptr.h" 15 #include "base/memory/scoped_ptr.h"
15 #include "base/process/kill.h" 16 #include "base/process/kill.h"
16 #include "content/browser/renderer_host/render_widget_host_impl.h" 17 #include "content/browser/renderer_host/render_widget_host_impl.h"
17 #include "content/browser/site_instance_impl.h" 18 #include "content/browser/site_instance_impl.h"
18 #include "content/common/drag_event_source_info.h" 19 #include "content/common/drag_event_source_info.h"
19 #include "content/public/browser/notification_observer.h" 20 #include "content/public/browser/notification_observer.h"
20 #include "content/public/browser/render_view_host.h" 21 #include "content/public/browser/render_view_host.h"
21 #include "content/public/common/javascript_message_type.h" 22 #include "content/public/common/javascript_message_type.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 58
58 namespace content { 59 namespace content {
59 60
60 class BrowserMediaPlayerManager; 61 class BrowserMediaPlayerManager;
61 class ChildProcessSecurityPolicyImpl; 62 class ChildProcessSecurityPolicyImpl;
62 class PageState; 63 class PageState;
63 class RenderWidgetHostDelegate; 64 class RenderWidgetHostDelegate;
64 class SessionStorageNamespace; 65 class SessionStorageNamespace;
65 class SessionStorageNamespaceImpl; 66 class SessionStorageNamespaceImpl;
66 class TestRenderViewHost; 67 class TestRenderViewHost;
68 class TimeoutMonitor;
67 struct FileChooserParams; 69 struct FileChooserParams;
68 struct Referrer; 70 struct Referrer;
69 struct ShowDesktopNotificationHostMsgParams; 71 struct ShowDesktopNotificationHostMsgParams;
70 72
71 #if defined(COMPILER_MSVC) 73 #if defined(COMPILER_MSVC)
72 // RenderViewHostImpl is the bottom of a diamond-shaped hierarchy, 74 // RenderViewHostImpl is the bottom of a diamond-shaped hierarchy,
73 // with RenderWidgetHost at the root. VS warns when methods from the 75 // with RenderWidgetHost at the root. VS warns when methods from the
74 // root are overridden in only one of the base classes and not both 76 // root are overridden in only one of the base classes and not both
75 // (in this case, RenderWidgetHostImpl provides implementations of 77 // (in this case, RenderWidgetHostImpl provides implementations of
76 // many of the methods). This is a silly warning when dealing with 78 // many of the methods). This is a silly warning when dealing with
(...skipping 14 matching lines...) Expand all
91 // 93 //
92 // Right now, the concept of page navigation (both top level and frame) exists 94 // Right now, the concept of page navigation (both top level and frame) exists
93 // in the WebContentsImpl still, so if you instantiate one of these elsewhere, 95 // in the WebContentsImpl still, so if you instantiate one of these elsewhere,
94 // you will not be able to traverse pages back and forward. We need to determine 96 // you will not be able to traverse pages back and forward. We need to determine
95 // if we want to bring that and other functionality down into this object so it 97 // if we want to bring that and other functionality down into this object so it
96 // can be shared by others. 98 // can be shared by others.
97 class CONTENT_EXPORT RenderViewHostImpl 99 class CONTENT_EXPORT RenderViewHostImpl
98 : public RenderViewHost, 100 : public RenderViewHost,
99 public RenderWidgetHostImpl { 101 public RenderWidgetHostImpl {
100 public: 102 public:
103 // Keeps track of the state of the RenderViewHostImpl, particularly with
104 // respect to swap out.
105 enum RenderViewHostImplState {
106 // The standard state for a RVH handling the communication with a
107 // RenderView.
108 STATE_DEFAULT = 0,
109 // The RVH has sent the SwapOut request to the renderer, but has not
110 // received the SwapOutACK yet. The new page has not been committed yet
111 // either.
112 STATE_WAITING_FOR_UNLOAD_ACK,
113 // The RVH received the SwapOutACK from the RenderView, but the new page has
114 // not been committed yet.
115 STATE_WAITING_FOR_COMMIT,
116 // The RVH is waiting for the CloseACK from the RenderView.
117 STATE_WAITING_FOR_CLOSE,
118 // The RVH has not received the SwapOutACK yet, but the new page has
119 // committed in a different RVH. The number of active views of the RVH
120 // SiteInstanceImpl is not zero. Upon reception of the SwapOutACK, the RVH
121 // will be swapped out.
122 STATE_PENDING_SWAP_OUT,
123 // The RVH has not received the SwapOutACK yet, but the new page has
124 // committed in a different RVH. The number of active views of the RVH
125 // SiteInstanceImpl is zero. Upon reception of the SwapOutACK, the RVH will
126 // be shutdown.
127 STATE_PENDING_SHUTDOWN,
128 // The RVH is swapped out, and it is being used as a placeholder to allow
129 // for cross-process communication.
130 STATE_SWAPPED_OUT,
131 };
132 // Helper function to determine whether the RVH state should contribute to the
133 // number of active views of a SiteInstance or not.
134 static bool IsRVHStateActive(RenderViewHostImplState rvh_state);
135
101 // Convenience function, just like RenderViewHost::FromID. 136 // Convenience function, just like RenderViewHost::FromID.
102 static RenderViewHostImpl* FromID(int render_process_id, int render_view_id); 137 static RenderViewHostImpl* FromID(int render_process_id, int render_view_id);
103 138
104 // |routing_id| could be a valid route id, or it could be MSG_ROUTING_NONE, in 139 // |routing_id| could be a valid route id, or it could be MSG_ROUTING_NONE, in
105 // which case RenderWidgetHost will create a new one. |swapped_out| indicates 140 // which case RenderWidgetHost will create a new one. |swapped_out| indicates
106 // whether the view should initially be swapped out (e.g., for an opener 141 // whether the view should initially be swapped out (e.g., for an opener
107 // frame being rendered by another process). |hidden| indicates whether the 142 // frame being rendered by another process). |hidden| indicates whether the
108 // view is initially hidden or visible. 143 // view is initially hidden or visible.
109 // 144 //
110 // The |session_storage_namespace| parameter allows multiple render views and 145 // The |session_storage_namespace| parameter allows multiple render views and
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 307
273 // Whether the initial empty page of this view has been accessed by another 308 // Whether the initial empty page of this view has been accessed by another
274 // page, making it unsafe to show the pending URL. Always false after the 309 // page, making it unsafe to show the pending URL. Always false after the
275 // first commit. 310 // first commit.
276 bool has_accessed_initial_document() { 311 bool has_accessed_initial_document() {
277 return has_accessed_initial_document_; 312 return has_accessed_initial_document_;
278 } 313 }
279 314
280 // Whether this RenderViewHost has been swapped out to be displayed by a 315 // Whether this RenderViewHost has been swapped out to be displayed by a
281 // different process. 316 // different process.
282 bool is_swapped_out() const { return is_swapped_out_; } 317 bool IsSwappedOut() const { return rvh_state_ == STATE_SWAPPED_OUT; }
318
319 // The current state of this RVH.
320 RenderViewHostImplState rvh_state() const { return rvh_state_; }
283 321
284 // Called on the pending RenderViewHost when the network response is ready to 322 // Called on the pending RenderViewHost when the network response is ready to
285 // commit. We should ensure that the old RenderViewHost runs its unload 323 // commit. We should ensure that the old RenderViewHost runs its unload
286 // handler and determine whether a transfer to a different RenderViewHost is 324 // handler and determine whether a transfer to a different RenderViewHost is
287 // needed. 325 // needed.
288 void OnCrossSiteResponse( 326 void OnCrossSiteResponse(
289 const GlobalRequestID& global_request_id, 327 const GlobalRequestID& global_request_id,
290 bool is_transfer, 328 bool is_transfer,
291 const std::vector<GURL>& transfer_url_chain, 329 const std::vector<GURL>& transfer_url_chain,
292 const Referrer& referrer, 330 const Referrer& referrer,
(...skipping 12 matching lines...) Expand all
305 // a blank document. The renderer should preserve the Frame object until it 343 // a blank document. The renderer should preserve the Frame object until it
306 // exits, in case we come back. The renderer can exit if it has no other 344 // exits, in case we come back. The renderer can exit if it has no other
307 // active RenderViews, but not until WasSwappedOut is called (when it is no 345 // active RenderViews, but not until WasSwappedOut is called (when it is no
308 // longer visible). 346 // longer visible).
309 void SwapOut(); 347 void SwapOut();
310 348
311 // Called when either the SwapOut request has been acknowledged or has timed 349 // Called when either the SwapOut request has been acknowledged or has timed
312 // out. 350 // out.
313 void OnSwappedOut(bool timed_out); 351 void OnSwappedOut(bool timed_out);
314 352
315 // Called to notify the renderer that it has been visibly swapped out and 353 // Called when the RenderFrameHostManager has swapped in a new
316 // replaced by another RenderViewHost, after an earlier call to SwapOut. 354 // RenderFrameHost. Should |this| RVH switch to the pending shutdown state,
317 // It is now safe for the process to exit if there are no other active 355 // |pending_delete_on_swap_out| will be executed upon reception of the
318 // RenderViews. 356 // SwapOutACK, or when the unload timer times out.
319 void WasSwappedOut(); 357 void WasSwappedOut(const base::Closure& pending_delete_on_swap_out);
358
359 // Set |this| as pending shutdown. |on_swap_out| will be called
360 // when the SwapOutACK is received, or when the unload timer times out.
361 void SetPendingShutdown(const base::Closure& on_swap_out);
320 362
321 // Close the page ignoring whether it has unload events registers. 363 // Close the page ignoring whether it has unload events registers.
322 // This is called after the beforeunload and unload events have fired 364 // This is called after the beforeunload and unload events have fired
323 // and the user has agreed to continue with closing the page. 365 // and the user has agreed to continue with closing the page.
324 void ClosePageIgnoringUnloadEvents(); 366 void ClosePageIgnoringUnloadEvents();
325 367
326 // Returns whether this RenderViewHost has an outstanding cross-site request. 368 // Returns whether this RenderViewHost has an outstanding cross-site request.
327 // Cleared when we hear the response and start to swap out the old 369 // Cleared when we hear the response and start to swap out the old
328 // RenderViewHost, or if we hear a commit here without a network request. 370 // RenderViewHost, or if we hear a commit here without a network request.
329 bool HasPendingCrossSiteRequest(); 371 bool HasPendingCrossSiteRequest();
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 const base::Closure& callback); 485 const base::Closure& callback);
444 void SetAccessibilityLoadCompleteCallbackForTesting( 486 void SetAccessibilityLoadCompleteCallbackForTesting(
445 const base::Closure& callback); 487 const base::Closure& callback);
446 void SetAccessibilityOtherCallbackForTesting( 488 void SetAccessibilityOtherCallbackForTesting(
447 const base::Closure& callback); 489 const base::Closure& callback);
448 490
449 bool is_waiting_for_beforeunload_ack() { 491 bool is_waiting_for_beforeunload_ack() {
450 return is_waiting_for_beforeunload_ack_; 492 return is_waiting_for_beforeunload_ack_;
451 } 493 }
452 494
453 bool is_waiting_for_unload_ack() { 495 // Whether the RVH is waiting for the unload ack from the renderer.
454 return is_waiting_for_unload_ack_; 496 bool IsWaitingForUnloadACK() const;
455 }
456 497
457 // Returns whether the given URL is allowed to commit in the current process. 498 // Returns whether the given URL is allowed to commit in the current process.
458 // This is a more conservative check than RenderProcessHost::FilterURL, since 499 // This is a more conservative check than RenderProcessHost::FilterURL, since
459 // it will be used to kill processes that commit unauthorized URLs. 500 // it will be used to kill processes that commit unauthorized URLs.
460 bool CanCommitURL(const GURL& url); 501 bool CanCommitURL(const GURL& url);
461 502
462 // Update the FrameTree to use this RenderViewHost's main frame 503 // Update the FrameTree to use this RenderViewHost's main frame
463 // RenderFrameHost. Called when the RenderViewHost is committed. 504 // RenderFrameHost. Called when the RenderViewHost is committed.
464 // 505 //
465 // TODO(ajwong): Remove once RenderViewHost no longer owns the main frame 506 // TODO(ajwong): Remove once RenderViewHost no longer owns the main frame
466 // RenderFrameHost. 507 // RenderFrameHost.
467 void AttachToFrameTree(); 508 void AttachToFrameTree();
468 509
469 // The following IPC handlers are public so RenderFrameHost can call them, 510 // The following IPC handlers are public so RenderFrameHost can call them,
470 // while we transition the code to not use RenderViewHost. 511 // while we transition the code to not use RenderViewHost.
471 // 512 //
472 // TODO(nasko): Remove those methods once we are done moving navigation 513 // TODO(nasko): Remove those methods once we are done moving navigation
473 // into RenderFrameHost. 514 // into RenderFrameHost.
474 void OnDidStartProvisionalLoadForFrame(int64 frame_id, 515 void OnDidStartProvisionalLoadForFrame(int64 frame_id,
475 int64 parent_frame_id, 516 int64 parent_frame_id,
476 bool main_frame, 517 bool main_frame,
477 const GURL& url); 518 const GURL& url);
478 519
520 // Increases the refcounting on this RVH. This is done by the FrameTree on
521 // creation of a RenderFrameHost.
522 void increment_ref_count() { ++frames_ref_count_; }
523
524 // Decreases the refcounting on this RVH. This is done by the FrameTree on
525 // destruction of a RenderFrameHost.
526 void decrement_ref_count() { --frames_ref_count_; }
527
528 // Returns the refcount on this RVH, that is the number of RenderFrameHosts
529 // currently using it.
530 int ref_count() { return frames_ref_count_; }
531
479 // NOTE: Do not add functions that just send an IPC message that are called in 532 // NOTE: Do not add functions that just send an IPC message that are called in
480 // one or two places. Have the caller send the IPC message directly (unless 533 // one or two places. Have the caller send the IPC message directly (unless
481 // the caller places are in different platforms, in which case it's better 534 // the caller places are in different platforms, in which case it's better
482 // to keep them consistent). 535 // to keep them consistent).
483 536
484 protected: 537 protected:
485 // RenderWidgetHost protected overrides. 538 // RenderWidgetHost protected overrides.
486 virtual void OnUserGesture() OVERRIDE; 539 virtual void OnUserGesture() OVERRIDE;
487 virtual void NotifyRendererUnresponsive() OVERRIDE; 540 virtual void NotifyRendererUnresponsive() OVERRIDE;
488 virtual void NotifyRendererResponsive() OVERRIDE; 541 virtual void NotifyRendererResponsive() OVERRIDE;
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 637
585 #if defined(OS_MACOSX) || defined(OS_ANDROID) 638 #if defined(OS_MACOSX) || defined(OS_ANDROID)
586 void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params); 639 void OnShowPopup(const ViewHostMsg_ShowPopup_Params& params);
587 #endif 640 #endif
588 641
589 private: 642 private:
590 friend class TestRenderViewHost; 643 friend class TestRenderViewHost;
591 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost); 644 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost);
592 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane); 645 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane);
593 646
594 // Sets whether this RenderViewHost is swapped out in favor of another, 647 // Updates the state of this RenderViewHost and clears any waiting state
595 // and clears any waiting state that is no longer relevant. 648 // that is no longer relevant.
596 void SetSwappedOut(bool is_swapped_out); 649 void SetState(RenderViewHostImplState rvh_state);
597 650
598 bool CanAccessFilesOfPageState(const PageState& state) const; 651 bool CanAccessFilesOfPageState(const PageState& state) const;
599 652
653 // The number of RenderFrameHosts which have a reference to this RVH.
654 int frames_ref_count_;
655
600 // Our delegate, which wants to know about changes in the RenderView. 656 // Our delegate, which wants to know about changes in the RenderView.
601 RenderViewHostDelegate* delegate_; 657 RenderViewHostDelegate* delegate_;
602 658
603 // The SiteInstance associated with this RenderViewHost. All pages drawn 659 // The SiteInstance associated with this RenderViewHost. All pages drawn
604 // in this RenderViewHost are part of this SiteInstance. Should not change 660 // in this RenderViewHost are part of this SiteInstance. Should not change
605 // over time. 661 // over time.
606 scoped_refptr<SiteInstanceImpl> instance_; 662 scoped_refptr<SiteInstanceImpl> instance_;
607 663
608 // true if we are currently waiting for a response for drag context 664 // true if we are currently waiting for a response for drag context
609 // information. 665 // information.
(...skipping 14 matching lines...) Expand all
624 // navigation, because WebContentsImpl will destroy the pending RVH and create 680 // navigation, because WebContentsImpl will destroy the pending RVH and create
625 // a new one if a second navigation occurs. 681 // a new one if a second navigation occurs.
626 scoped_ptr<ViewMsg_Navigate_Params> suspended_nav_params_; 682 scoped_ptr<ViewMsg_Navigate_Params> suspended_nav_params_;
627 683
628 // Whether the initial empty page of this view has been accessed by another 684 // Whether the initial empty page of this view has been accessed by another
629 // page, making it unsafe to show the pending URL. Usually false unless 685 // page, making it unsafe to show the pending URL. Usually false unless
630 // another window tries to modify the blank page. Always false after the 686 // another window tries to modify the blank page. Always false after the
631 // first commit. 687 // first commit.
632 bool has_accessed_initial_document_; 688 bool has_accessed_initial_document_;
633 689
634 // Whether this RenderViewHost is currently swapped out, such that the view is 690 // The current state of this RVH.
635 // being rendered by another process. 691 RenderViewHostImplState rvh_state_;
636 bool is_swapped_out_;
637 692
638 // The frame id of the main (top level) frame. This value is set on the 693 // The frame id of the main (top level) frame. This value is set on the
639 // initial navigation of a RenderView and reset when the RenderView's 694 // initial navigation of a RenderView and reset when the RenderView's
640 // process is terminated (in RenderProcessGone). 695 // process is terminated (in RenderProcessGone).
641 // TODO(creis): Remove this when we switch to routing IDs for frames. 696 // TODO(creis): Remove this when we switch to routing IDs for frames.
642 int64 main_frame_id_; 697 int64 main_frame_id_;
643 698
644 // Routing ID for the main frame's RenderFrameHost. 699 // Routing ID for the main frame's RenderFrameHost.
645 int main_frame_routing_id_; 700 int main_frame_routing_id_;
646 701
647 // If we were asked to RunModal, then this will hold the reply_msg that we 702 // If we were asked to RunModal, then this will hold the reply_msg that we
648 // must return to the renderer to unblock it. 703 // must return to the renderer to unblock it.
649 IPC::Message* run_modal_reply_msg_; 704 IPC::Message* run_modal_reply_msg_;
650 // This will hold the routing id of the RenderView that opened us. 705 // This will hold the routing id of the RenderView that opened us.
651 int run_modal_opener_id_; 706 int run_modal_opener_id_;
652 707
653 // Set to true when there is a pending ViewMsg_ShouldClose message. This 708 // Set to true when there is a pending ViewMsg_ShouldClose message. This
654 // ensures we don't spam the renderer with multiple beforeunload requests. 709 // ensures we don't spam the renderer with multiple beforeunload requests.
655 // When either this value or is_waiting_for_unload_ack_ is true, the value of 710 // When either this value or IsWaitingForUnloadACK is true, the value of
656 // unload_ack_is_for_cross_site_transition_ indicates whether this is for a 711 // unload_ack_is_for_cross_site_transition_ indicates whether this is for a
657 // cross-site transition or a tab close attempt. 712 // cross-site transition or a tab close attempt.
713 // TODO(clamy): Remove this boolean and add one more state to the state
714 // machine.
658 bool is_waiting_for_beforeunload_ack_; 715 bool is_waiting_for_beforeunload_ack_;
659 716
660 // Set to true when there is a pending ViewMsg_Close message. Also see
661 // is_waiting_for_beforeunload_ack_, unload_ack_is_for_cross_site_transition_.
662 bool is_waiting_for_unload_ack_;
663
664 // Set to true when waiting for ViewHostMsg_SwapOut_ACK has timed out.
665 bool has_timed_out_on_unload_;
666
667 // Valid only when is_waiting_for_beforeunload_ack_ or 717 // Valid only when is_waiting_for_beforeunload_ack_ or
668 // is_waiting_for_unload_ack_ is true. This tells us if the unload request 718 // IsWaitingForUnloadACK is true. This tells us if the unload request
669 // is for closing the entire tab ( = false), or only this RenderViewHost in 719 // is for closing the entire tab ( = false), or only this RenderViewHost in
670 // the case of a cross-site transition ( = true). 720 // the case of a cross-site transition ( = true).
671 bool unload_ack_is_for_cross_site_transition_; 721 bool unload_ack_is_for_cross_site_transition_;
672 722
673 bool are_javascript_messages_suppressed_; 723 bool are_javascript_messages_suppressed_;
674 724
675 // The mapping of pending javascript calls created by 725 // The mapping of pending javascript calls created by
676 // ExecuteJavascriptInWebFrameCallbackResult and their corresponding 726 // ExecuteJavascriptInWebFrameCallbackResult and their corresponding
677 // callbacks. 727 // callbacks.
678 std::map<int, JavascriptResultCallback> javascript_callbacks_; 728 std::map<int, JavascriptResultCallback> javascript_callbacks_;
(...skipping 14 matching lines...) Expand all
693 base::TimeTicks send_should_close_start_time_; 743 base::TimeTicks send_should_close_start_time_;
694 744
695 // Set to true if we requested the on screen keyboard to be displayed. 745 // Set to true if we requested the on screen keyboard to be displayed.
696 bool virtual_keyboard_requested_; 746 bool virtual_keyboard_requested_;
697 747
698 #if defined(OS_ANDROID) 748 #if defined(OS_ANDROID)
699 // Manages all the android mediaplayer objects and handling IPCs for video. 749 // Manages all the android mediaplayer objects and handling IPCs for video.
700 scoped_ptr<BrowserMediaPlayerManager> media_player_manager_; 750 scoped_ptr<BrowserMediaPlayerManager> media_player_manager_;
701 #endif 751 #endif
702 752
753 // Used to swap out or shutdown this RVH when the unload event is taking too
754 // long to execute, depending on the number of active views in the
755 // SiteInstance.
756 scoped_ptr<TimeoutMonitor> unload_event_monitor_timeout_;
757
758 // Called after receiving the SwapOutACK when the RVH is in state pending
759 // shutdown. Also called if the unload timer times out.
760 base::Closure pending_shutdown_on_swap_out_;
761
762 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
763
703 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 764 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
704 }; 765 };
705 766
706 #if defined(COMPILER_MSVC) 767 #if defined(COMPILER_MSVC)
707 #pragma warning(pop) 768 #pragma warning(pop)
708 #endif 769 #endif
709 770
710 } // namespace content 771 } // namespace content
711 772
712 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 773 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698