Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 885003003: Roll WebRTC 8176:8203, Libjingle 8174:8202 (Closed)

Created:
5 years, 10 months ago by tommi (sloooow) - chröme
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Include fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_not_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_not_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
tommi (sloooow) - chröme
5 years, 10 months ago (2015-01-29 12:42:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885003003/1
5 years, 10 months ago (2015-01-29 12:42:32 UTC) #3
kjellander_chromium
Looking at http://build.chromium.org/p/chromium.webrtc.fyi/waterfall I'm not sure this compiles yet. Bots haven't recovered/caught up just yet.
5 years, 10 months ago (2015-01-29 12:49:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/49877)
5 years, 10 months ago (2015-01-29 12:58:56 UTC) #6
tommi (sloooow) - chröme
Include fix
5 years, 10 months ago (2015-01-29 13:27:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885003003/20001
5 years, 10 months ago (2015-01-29 13:28:12 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8aa707b5aa26cead2ab4791672163337c92f904b Cr-Commit-Position: refs/heads/master@{#313705}
5 years, 10 months ago (2015-01-29 14:56:06 UTC) #10
tommi (sloooow) - chröme
Committed patchset #2 (id:20001) manually as 8aa707b5aa26cead2ab4791672163337c92f904b (presubmit successful).
5 years, 10 months ago (2015-01-29 14:56:32 UTC) #11
please use gerrit instead
5 years, 10 months ago (2015-01-29 15:55:40 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/888593002/ by rouslan@chromium.org.

The reason for reverting is: Appears to have broken Mac browser tests:

 - WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams
 - WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs

[75316:29699:0129/074049:FATAL:overuse_frame_detector.cc(388)] Check failed:
processing_thread_.CalledOnValidThread().
0   libbase.dylib                       0x0000000119eaf88f
base::debug::StackTrace::StackTrace() + 47
1   libbase.dylib                       0x0000000119eaf8e3
base::debug::StackTrace::StackTrace() + 35
2   libbase.dylib                       0x0000000119f09076
logging::LogMessage::~LogMessage() + 70
3   libbase.dylib                       0x0000000119f080c3
logging::LogMessage::~LogMessage() + 35
4   libcontent.dylib                    0x000000012ce82cd5
webrtc::OveruseFrameDetector::TimeUntilNextProcess() + 245
5   libcontent.dylib                    0x000000012c8dfdfd
webrtc::ProcessThreadImpl::Process() + 525
6   libcontent.dylib                    0x000000012c8df836
webrtc::ProcessThreadImpl::Run(void*) + 38
7   libcontent.dylib                    0x000000012c6ce390
webrtc::ThreadPosix::Run() + 288
8   libcontent.dylib                    0x000000012c6ce076
webrtc::StartThread(void*) + 38
9   libsystem_pthread.dylib             0x00007fff8fe5f899 _pthread_body + 138
10  libsystem_pthread.dylib             0x00007fff8fe5f72a _pthread_struct_init
+ 0
11  libsystem_pthread.dylib             0x00007fff8fe63fc9 thread_start + 13

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....

Powered by Google App Engine
This is Rietveld 408576698