Chromium Code Reviews
Help | Chromium Project | Sign in
(879)

Issue 8850004: Add a context field to the accessibility extension API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by dmazzoni
Modified:
2 years, 4 months ago
CC:
chromium-reviews_chromium.org, jstritar+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, PaweĊ‚ Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Add a context field to the accessibility extension API.
This makes it possible to provide more helpful spoken feedback when focusing
a toolbar button or infobar button - e.g. it can now read the full text of
the infobar when you move focus to any of its buttons.

BUG=106724
TEST=Adds new unit tests; will need new ChromeVox push to test manually.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114640

Patch Set 1 #

Total comments: 15

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -42 lines) Lint Patch
M chrome/browser/accessibility/accessibility_events.h View 1 2 3 4 10 chunks +23 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/accessibility/accessibility_events.cc View 1 2 3 4 15 chunks +27 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/accessibility/accessibility_extension_api_constants.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/browser/accessibility/accessibility_extension_api_constants.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/browser/chromeos/login/wizard_accessibility_handler_unittest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/ui/views/accessibility_event_router_views.h View 1 2 3 4 1 chunk +50 lines, -22 lines 0 comments 0 errors Download
M chrome/browser/ui/views/accessibility_event_router_views.cc View 1 2 3 4 10 chunks +82 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 3 4 4 chunks +109 lines, -0 lines 0 comments 0 errors Download
M chrome/common/extensions/api/extension_api.json View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 12
dmazzoni
hashimoto: primary reviewer sky: chrome/browser/ui/views/ aa: rubberstamp for private extension api change
2 years, 4 months ago #1
dmazzoni
2 years, 4 months ago #2
sky
http://codereview.chromium.org/8850004/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc File chrome/browser/ui/views/accessibility_event_router_views.cc (right): http://codereview.chromium.org/8850004/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc#newcode299 chrome/browser/ui/views/accessibility_event_router_views.cc:299: void AccessibilityEventRouterViews::AddContextInfo( Order should match header. http://codereview.chromium.org/8850004/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc#newcode323 chrome/browser/ui/views/accessibility_event_router_views.cc:323: if ...
2 years, 4 months ago #3
hashimoto
http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h File chrome/browser/accessibility/accessibility_events.h (right): http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h#newcode63 chrome/browser/accessibility/accessibility_events.h:63: void set_context(const std::string& context) { context_ = context; } ...
2 years, 4 months ago #4
dmazzoni
http://codereview.chromium.org/8850004/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc File chrome/browser/ui/views/accessibility_event_router_views.cc (right): http://codereview.chromium.org/8850004/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc#newcode299 chrome/browser/ui/views/accessibility_event_router_views.cc:299: void AccessibilityEventRouterViews::AddContextInfo( On 2011/12/07 22:01:55, sky wrote: > Order ...
2 years, 4 months ago #5
dmazzoni
http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h File chrome/browser/accessibility/accessibility_events.h (right): http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h#newcode63 chrome/browser/accessibility/accessibility_events.h:63: void set_context(const std::string& context) { context_ = context; } ...
2 years, 4 months ago #6
hashimoto
http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h File chrome/browser/accessibility/accessibility_events.h (right): http://codereview.chromium.org/8850004/diff/1/chrome/browser/accessibility/accessibility_events.h#newcode63 chrome/browser/accessibility/accessibility_events.h:63: void set_context(const std::string& context) { context_ = context; } ...
2 years, 4 months ago #7
dmazzoni
On Wed, Dec 7, 2011 at 4:04 PM, <hashimoto@chromium.org> wrote: > How about having two ...
2 years, 4 months ago #8
dmazzoni
On Wed, Dec 7, 2011 at 7:37 PM, Dominic Mazzoni <dmazzoni@chromium.org>wrote: > On Wed, Dec ...
2 years, 4 months ago #9
sky
LGTM http://codereview.chromium.org/8850004/diff/9003/chrome/browser/ui/views/accessibility_event_router_views.h File chrome/browser/ui/views/accessibility_event_router_views.h (right): http://codereview.chromium.org/8850004/diff/9003/chrome/browser/ui/views/accessibility_event_router_views.h#newcode111 chrome/browser/ui/views/accessibility_event_router_views.h:111: ui::AccessibilityTypes::Role role); This is the preferred wrapping style ...
2 years, 4 months ago #10
dmazzoni
http://codereview.chromium.org/8850004/diff/9003/chrome/browser/ui/views/accessibility_event_router_views.h File chrome/browser/ui/views/accessibility_event_router_views.h (right): http://codereview.chromium.org/8850004/diff/9003/chrome/browser/ui/views/accessibility_event_router_views.h#newcode111 chrome/browser/ui/views/accessibility_event_router_views.h:111: ui::AccessibilityTypes::Role role); On 2011/12/12 16:20:58, sky wrote: > This ...
2 years, 4 months ago #11
hashimoto
2 years, 4 months ago #12
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6