Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 884933002: ★ Add Bookmarks Bar to the list of primary permanent nodes. (Closed)

Created:
5 years, 10 months ago by lpromero
Modified:
5 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

★ Add Bookmarks Bar to the list of primary permanent nodes. As per https://docs.google.com/document/d/1aerLjBm5jc7OILH0BDZmDX8npqop38zfnSO824LnH00, all permanent nodes are treated equally. BUG=453197 Committed: https://crrev.com/9f946c94e2fb8428ee5d35eda446c7a4edcbc918 Cr-Commit-Position: refs/heads/master@{#313918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M components/enhanced_bookmarks/enhanced_bookmark_utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_utils.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lpromero
5 years, 10 months ago (2015-01-29 02:33:44 UTC) #2
Kibeom Kim (inactive)
Clank doesn't use this yet (probably we should) so it's not affected. Thanks! I'll defer ...
5 years, 10 months ago (2015-01-29 02:36:54 UTC) #3
noyau (Ping after 24h)
lgtm
5 years, 10 months ago (2015-01-29 09:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884933002/1
5 years, 10 months ago (2015-01-29 10:07:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884933002/1
5 years, 10 months ago (2015-01-30 15:23:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 15:24:16 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 15:24:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f946c94e2fb8428ee5d35eda446c7a4edcbc918
Cr-Commit-Position: refs/heads/master@{#313918}

Powered by Google App Engine
This is Rietveld 408576698