Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 884923004: [Profiles] Delete test-only method from the ProfileInfoCache (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Profiles] Delete test-only method from the ProfileInfoCache And move it to the only test that cares about it. BUG=363524 TEST=Existing unit tests. Committed: https://crrev.com/693f35aa1676ba7ff2d3ba7e950f56f20d510fe0 Cr-Commit-Position: refs/heads/master@{#314820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
Brace yourself, refactor CLs are coming.
5 years, 10 months ago (2015-02-04 17:43:15 UTC) #2
Mike Lerman
lgtm
5 years, 10 months ago (2015-02-05 13:43:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884923004/1
5 years, 10 months ago (2015-02-05 15:59:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 16:03:44 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 16:04:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/693f35aa1676ba7ff2d3ba7e950f56f20d510fe0
Cr-Commit-Position: refs/heads/master@{#314820}

Powered by Google App Engine
This is Rietveld 408576698