Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 884873004: DevTools: rename RenderViewDevToolsAgentHost to RenderFrame*. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
Reviewers:
dgozman, nasko
CC:
chromium-reviews, James Su, vsevik, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, yurys, nona+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename RenderViewDevToolsAgentHost to RenderFrame*. R=dgozman TBR=nasko BUG=451004 Committed: https://crrev.com/1edcc014467657527a7926a5a0109fb56d5ec186 Cr-Commit-Position: refs/heads/master@{#313745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -734 lines) Patch
M content/browser/devtools/devtools_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + content/browser/devtools/render_frame_devtools_agent_host.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/devtools/render_frame_devtools_agent_host.cc View 27 chunks +54 lines, -53 lines 0 comments Download
D content/browser/devtools/render_view_devtools_agent_host.h View 1 chunk +0 lines, -139 lines 0 comments Download
D content/browser/devtools/render_view_devtools_agent_host.cc View 1 chunk +0 lines, -526 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
5 years, 10 months ago (2015-01-29 12:54:28 UTC) #2
dgozman
lgtm
5 years, 10 months ago (2015-01-29 13:58:00 UTC) #3
nasko
LGTM
5 years, 10 months ago (2015-01-29 17:36:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884873004/1
5 years, 10 months ago (2015-01-29 17:45:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 18:40:00 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:41:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1edcc014467657527a7926a5a0109fb56d5ec186
Cr-Commit-Position: refs/heads/master@{#313745}

Powered by Google App Engine
This is Rietveld 408576698