Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 884873002: Merge to Master: Cover fpdftext.h API with embeddertests. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -35 lines) Patch
M fpdfsdk/include/fpdftext.h View 8 chunks +21 lines, -17 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +346 lines, -0 lines 0 comments Download
A + testing/resources/hello_world.in View 2 chunks +12 lines, -4 lines 0 comments Download
A + testing/resources/hello_world.pdf View 2 chunks +17 lines, -8 lines 0 comments Download
A testing/resources/weblinks.in View 1 chunk +66 lines, -0 lines 0 comments Download
A testing/resources/weblinks.pdf View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Merge is in opposite direction since I unintentionally developed the test while on an XFA ...
5 years, 10 months ago (2015-01-28 23:54:50 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 90f9e6180384672db231e52c417c55c6f8a5872a (presubmit successful).
5 years, 10 months ago (2015-01-28 23:55:12 UTC) #2
Lei Zhang
5 years, 10 months ago (2015-01-29 01:10:59 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698