Recording in UMA when a user interacted with an address form or a credit card form.

components/autofill/core/browser/autofill_metrics.cc

Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index 21ca9f840d9ecad5624ba2474946b25d9dea0de2..5189dd5274c46c4e59dcee920c09f2907fa383e8 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -465,4 +465,67 @@ void AutofillMetrics::LogAddressSuggestionsCount(size_t num_suggestions) {
   UMA_HISTOGRAM_COUNTS("Autofill.AddressSuggestionsCount", num_suggestions);
 }
 
+AutofillMetrics::FormEventLogger::FormEventLogger(
+    bool is_credit_card,
+    bool is_server_data_available,
+    bool is_local_data_available)
+    : is_credit_card_(is_credit_card),
+      is_server_data_available_(is_server_data_available),
+      is_local_data_available_(is_local_data_available) {};
+
+void AutofillMetrics::FormEventLogger::Log(AutofillFormEvent event) {
+  DCHECK_LT(event, NUM_AUTOFILL_FORM_EVENTS);
+  std::string custom_name("Autofill.FormEvents.");

[Evan Stade, 2015/01/30 19:39:49]

?

[Walter Cacau, 2015/01/30 22:05:56]

ops
old code from when I tried dynamically generating the histogram name.

+  if (is_credit_card_) {
+    UMA_HISTOGRAM_ENUMERATION("Autofill.FormEvents.CreditCard", event,
+                              NUM_AUTOFILL_FORM_EVENTS);
+  } else {
+    UMA_HISTOGRAM_ENUMERATION("Autofill.FormEvents.Address", event,
+                              NUM_AUTOFILL_FORM_EVENTS);
+  }
+
+  // Logging again in a different histogram for segmentation purposes.
+  if (!is_server_data_available_ && !is_local_data_available_) {
+    if (is_credit_card_) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.CreditCard.WithNoData",

[Evan Stade, 2015/01/30 19:39:50]

this code could be a bit less verbose --

const char* kCreditCard = "CreditCard";
const char* fill_type = is_credit_card_ ? kCreditCard : kAddress;

if (...
  UMA_HISTOGRAM_ENUMERATION("Foobar.baz." + fill_type + ".WithNoData");
else if (...
  UMA_HISTOGRAM_ENUMERATION("Foobar.bag." + fill_type + ".WithOnlyServerData");
else if (...

etc.

you might have to use a #define, or something

[Walter Cacau, 2015/01/30 22:05:56]

So, I actually had code like that but the UMA macro defines a static variable
that contains the histogram and it is supposed to be used for exactly one. The
internal UMA code actually stores the first histogram name one it sees from a
call and if any subsequent call tries to use something different an assertion
fails.

There may be another better API to UMA to replace this, but I don't know which.

[Evan Stade, 2015/01/30 22:35:15]

pretty sure you could still do this somehow with macros

#define TYPE_SPECIFIC_HISTOGRAM(a, b, c, d, e) \
  if (a)\
    UMA_HISTOGRAM_ENUMERATION(b "CreditCard" c, d, e);\
  else\
    UMA_HISTOGRAM_ENUMERATION(b "Address" c, d, e)

[Ilya Sherman, 2015/01/30 22:38:05]

Alternately, you can inline the macro definition, as is done in other parts of
this file (mostly toward the top, IIRC).

[Walter Cacau, 2015/01/31 00:35:55]

Done.

+          event, NUM_AUTOFILL_FORM_EVENTS);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.Address.WithNoData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    }
+  } else if (is_server_data_available_ && !is_local_data_available_) {
+    if (is_credit_card_) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.CreditCard.WithOnlyServerData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.Address.WithOnlyServerData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    }
+  } else if (!is_server_data_available_ && is_local_data_available_) {
+    if (is_credit_card_) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.CreditCard.WithOnlyLocalData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.Address.WithOnlyLocalData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    }
+  } else {
+    if (is_credit_card_) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.CreditCard.WithBothServerAndLocalData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    } else {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Autofill.FormEvents.Address.WithBothServerAndLocalData",
+          event, NUM_AUTOFILL_FORM_EVENTS);
+    }
+  }
+}
+
 }  // namespace autofill