Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 884843002: Recording in UMA when a user interacted with an address form or a credit card form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inlining web_profiles() call Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index ec9286c4ac8296614ee7a6c364fc60614cee0747..e3690b4990aa6675da92e3a10a23c446ae6805b2 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -23,6 +23,7 @@
#include "components/autofill/core/browser/autofill_client.h"
#include "components/autofill/core/browser/autofill_download_manager.h"
#include "components/autofill/core/browser/autofill_driver.h"
+#include "components/autofill/core/browser/autofill_metrics.h"
#include "components/autofill/core/browser/card_unmask_delegate.h"
#include "components/autofill/core/browser/form_structure.h"
#include "components/autofill/core/browser/personal_data_manager.h"
@@ -231,7 +232,7 @@ class AutofillManager : public AutofillDownloadManager::Observer,
void OnUnmaskVerificationResult(bool success);
// Returns false if Autofill is disabled or if no Autofill data is available.
- bool RefreshDataModels() const;
+ bool RefreshDataModels();
// Unpacks |unique_id| and fills |form_group| and |variant| with the
// appropriate data source and variant index. Sets |is_credit_card| to true
@@ -332,6 +333,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,
// Handles single-field autocomplete form data.
scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
+ // Utilities for logging form events.
+ scoped_ptr<AutofillMetrics::FormEventLogger> address_form_event_logger_;
+ scoped_ptr<AutofillMetrics::FormEventLogger> credit_card_form_event_logger_;
+
// Have we logged whether Autofill is enabled for this page load?
bool has_logged_autofill_enabled_;
// Have we logged an address suggestions count metric for this page?
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698