components/autofill/core/browser/personal_data_manager.h - Issue 884843002: Recording in UMA when a user interacted with an address form or a credit card form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 884843002: Recording in UMA when a user interacted with an address form or a credit card form. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing test_personal_data_manager. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | components/autofill/core/browser/personal_data_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.h

diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h

index ef66ce6f6db03137628d0326c3dab4a5fefea5bb..20cfaf60f1b5f3689495472ae44a8b3ff9c0f582 100644

--- a/components/autofill/core/browser/personal_data_manager.h

+++ b/components/autofill/core/browser/personal_data_manager.h

@@ -340,7 +340,7 @@ class PersonalDataManager : public KeyedService,

// Functionally equivalent to GetProfiles(), but also records metrics if

// |record_metrics| is true. Metrics should be recorded when the returned

// profiles will be used to populate the fields shown in an Autofill popup.

- const std::vector<AutofillProfile*>& GetProfiles(

+ virtual const std::vector<AutofillProfile*>& GetProfiles(

bool record_metrics) const;

const std::string app_locale_;